gpu/config: remove CollectGpuID

gpu/config: remove CollectGpuID

Use CollectBasicGraphicsInfo instead, which is a superset. The
additional gathering done in CollectBasicGraphicsInfo is ok as it
CollectGpuID was only called in tests, and on the infrequent display
reconfigure on Mac (and collecting info is fast on Mac).

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2729103004
Cr-Commit-Position: refs/heads/master@{#454644}
Committed: https://chromium.googlesource.com/chromium/src/+/d41fc4a8509076f5c675162d010c493df0a40bde

[Corentin Wallez, 2017-03-03 15:42:47]

Description was changed from

==========
gpu/config: remove CollectGpuID

Use CollectBasicGraphicsInfo instead, which is a superset. The
additional gathering done in CollectBasicGraphicsInfo is ok as it
CollectGpuID was only called in tests, and on the infrequent display
reconfigure on Mac (and collecting info is fast on Mac).

BUG=angleproject:1874
==========

to

==========
gpu/config: remove CollectGpuID

Use CollectBasicGraphicsInfo instead, which is a superset. The
additional gathering done in CollectBasicGraphicsInfo is ok as it
CollectGpuID was only called in tests, and on the infrequent display
reconfigure on Mac (and collecting info is fast on Mac).

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2017-03-03 15:42:58]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 15:43:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 16:03:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 16:03:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Corentin Wallez, 2017-03-03 16:19:21]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 16:19:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 16:38:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 16:38:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Corentin Wallez, 2017-03-03 16:55:42]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 16:55:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 17:42:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 17:42:50]

Dry run: This issue passed the CQ dry run.

[Corentin Wallez, 2017-03-03 18:06:04]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2017-03-03 18:06:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 18:06:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 18:06:28]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Corentin Wallez, 2017-03-03 18:06:29]

cwallez@chromium.org changed reviewers:
+ zmo@chromium.org

[Corentin Wallez, 2017-03-03 18:06:29]

PTAL, this will avoid the need to implement a special function to only get info
about the primary GPU.

[Zhenyao Mo, 2017-03-03 18:47:33]

lgtm
Thanks for cleaning this up

[Corentin Wallez, 2017-03-03 19:12:00]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2017-03-03 19:12:00]

Thanks for the review

[commit-bot: I haz the power, 2017-03-03 19:12:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 19:17:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488568320043480,
"parent_rev": "708d811b51acf9702fa2db536434115413acdb52", "commit_rev":
"d41fc4a8509076f5c675162d010c493df0a40bde"}

[commit-bot: I haz the power, 2017-03-03 19:17:39]

Description was changed from

==========
gpu/config: remove CollectGpuID

Use CollectBasicGraphicsInfo instead, which is a superset. The
additional gathering done in CollectBasicGraphicsInfo is ok as it
CollectGpuID was only called in tests, and on the infrequent display
reconfigure on Mac (and collecting info is fast on Mac).

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu/config: remove CollectGpuID

Use CollectBasicGraphicsInfo instead, which is a superset. The
additional gathering done in CollectBasicGraphicsInfo is ok as it
CollectGpuID was only called in tests, and on the infrequent display
reconfigure on Mac (and collecting info is fast on Mac).

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2729103004
Cr-Commit-Position: refs/heads/master@{#454644}
Committed:
https://chromium.googlesource.com/chromium/src/+/d41fc4a8509076f5c675162d010c...
==========

[commit-bot: I haz the power, 2017-03-03 19:17:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d41fc4a8509076f5c675162d010c...

[ccameron, 2017-05-12 23:46:09]

ccameron@chromium.org changed reviewers:
+ ccameron@chromium.org

[ccameron, 2017-05-12 23:46:10]

https://codereview.chromium.org/2729103004/diff/40001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2729103004/diff/40001/content/browser/gpu/gpu...
content/browser/gpu/gpu_data_manager_impl_private.cc:247:
gpu_info.gpu.device_id);
For dual-GPU macs, gpu_info.gpu always refers to the dGPU.

I think that this was supposed to be the active GPU.