Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2729073002: Fix DirectCompositionSurfaceTest.TestMakeCurrent flakiness. (Closed)

Created:
3 years, 9 months ago by jbauman
Modified:
3 years, 9 months ago
Reviewers:
stanisc
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DirectCompositionSurfaceTest.TestMakeCurrent flakiness. The tasks to delete the window owner threads could be posted to the main thread after the main thread ran RunUntilIdle. This causes the window owner threads and their MessagePumpForUI to outlive the main test, and that causes a DCHECK when the test tries to get rid of the MessageWindow class atom that the message pump is currently using. BUG=697929 TBR=stanisc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2729073002 Cr-Commit-Position: refs/heads/master@{#454475} Committed: https://chromium.googlesource.com/chromium/src/+/3051724ad6cbc2e32743085786bd362bd1f06a61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M gpu/ipc/service/child_window_win.h View 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/ipc/service/child_window_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win_unittest.cc View 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729073002/1
3 years, 9 months ago (2017-03-03 00:21:07 UTC) #3
stanisc
lgtm
3 years, 9 months ago (2017-03-03 01:36:06 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 02:35:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3051724ad6cbc2e32743085786bd...

Powered by Google App Engine
This is Rietveld 408576698