Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issue 2729033002: Make .clang-format files smaller after clang-format roll

Created:
2 years, 11 months ago by Nico
Modified:
2 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make .clang-format files smaller after clang-format roll -style=Chromium now enables include sorting implicitly, so no need to turn that on explicitly anymore. Likewise, AllowShortFunctionsOnASingleLine now defaults to Empty. Finally, all grit instructions in .js files are now in comments, so `JavaScriptQuotes: Leave` is no longer needed either. (Also move a few last straggler <include>s that weren't in comments yet into comments.) No intended behavior change. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -23 lines) Patch
M .clang-format View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/.clang-format View 1 chunk +0 lines, -8 lines 0 comments Download
M components/dom_distiller/core/javascript/domdistiller.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/locales/en.js View 1 1 chunk +1 line, -1 line 1 comment Download
D ui/webui/resources/.clang-format View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/webui/resources/js/analytics.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/jstemplate_compiled.js View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 14 (9 generated)
Nico
2 years, 11 months ago (2017-03-02 14:53:06 UTC) #8
Nico
Huh, compile failure actually looks related: FAILED: gen/android_webview/generate_webui_resources_stamp.d.stamp gen/android_webview/grit/webui_resources.h gen/android_webview/grit/webui_resources_map.h gen/android_webview/grit/webui_resources_map.cc gen/android_webview/webui_resources.pak python ../../tools/grit/grit.py -i ...
2 years, 11 months ago (2017-03-02 15:16:23 UTC) #11
Dan Beam
https://codereview.chromium.org/2729033002/diff/20001/ui/webui/resources/js/jstemplate_compiled.js File ui/webui/resources/js/jstemplate_compiled.js (right): https://codereview.chromium.org/2729033002/diff/20001/ui/webui/resources/js/jstemplate_compiled.js#newcode8 ui/webui/resources/js/jstemplate_compiled.js:8: // <include src="../../../../third_party/jstemplate/jstemplate_compiled.js"> yeahhhhh you can only do this ...
2 years, 11 months ago (2017-03-02 20:50:07 UTC) #12
Dan Beam
https://codereview.chromium.org/2729033002/diff/20001/ui/keyboard/resources/locales/en.js File ui/keyboard/resources/locales/en.js (right): https://codereview.chromium.org/2729033002/diff/20001/ui/keyboard/resources/locales/en.js#newcode5 ui/keyboard/resources/locales/en.js:5: // <include src="../../../../third_party/google_input_tools/src/chrome/os/inputview/_locales/en/messages.json"> you can't do this either, it's ...
2 years, 11 months ago (2017-03-02 20:51:04 UTC) #13
Dan Beam
2 years, 11 months ago (2017-03-02 20:51:50 UTC) #14
lgtm

you could also add comments to the top of the 2 third_party files without a
copyright on top to fix the jstemplate (and analytics?) <include>s

Powered by Google App Engine
This is Rietveld 408576698