Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2728963004: Remove non-standard DeviceOrientation Event initializers. (Closed)

Created:
3 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-standard DeviceOrientation Event initializers. This patch removes DeviceOrientationEvent.initDeviceOrientationEvent and DeviceMotionEvent.initDeviceMotionEvent and rewrites the LayoutTests to use the constructors for these objects instead. https://www.w3.org/TR/2016/CR-orientation-event-20160818/ BUG=697598 Review-Url: https://codereview.chromium.org/2728963004 Cr-Commit-Position: refs/heads/master@{#457849} Committed: https://chromium.googlesource.com/chromium/src/+/0921e8319f228e406019b434701ac9f181ee8ea1

Patch Set 1 #

Patch Set 2 : Remove initializers from more webexposed expectations. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -312 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html View 4 chunks +46 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties-expected.txt View 4 chunks +46 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties.html View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp View 1 chunk +0 lines, -162 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/custom.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl View 1 2 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
Reilly Grant (use Gerrit)
timvolodine@, please review device_orientation changes. pfeldman@, please review custom bindings changes.
3 years, 9 months ago (2017-03-02 21:36:23 UTC) #6
pfeldman
code removed => lgtm!
3 years, 9 months ago (2017-03-02 21:37:59 UTC) #7
timvolodine
On 2017/03/02 21:37:59, pfeldman wrote: > code removed => lgtm! lgtm, thanks :) maybe link ...
3 years, 9 months ago (2017-03-02 22:28:43 UTC) #8
haraken
bindings LGTM
3 years, 9 months ago (2017-03-02 23:03:35 UTC) #11
Reilly Grant (use Gerrit)
Remove initializers from more webexposed expectations.
3 years, 9 months ago (2017-03-02 23:13:06 UTC) #12
Reilly Grant (use Gerrit)
Adding foolip@ as API_OWNERS.
3 years, 9 months ago (2017-03-02 23:16:15 UTC) #17
foolip
This web-facing removal is likely enough to cause some trouble that an Intent to Deprecate ...
3 years, 9 months ago (2017-03-03 15:00:41 UTC) #20
foolip
On 2017/03/03 15:00:41, foolip wrote: > already implemented I mean implemented in all engines, obviously ...
3 years, 9 months ago (2017-03-03 15:01:29 UTC) #21
dglazkov
lgtm
3 years, 9 months ago (2017-03-17 17:10:41 UTC) #23
Reilly Grant (use Gerrit)
Rebased.
3 years, 9 months ago (2017-03-17 17:15:01 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728963004/40001
3 years, 9 months ago (2017-03-17 17:15:48 UTC) #27
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 19:27:48 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0921e8319f228e406019b434701a...

Powered by Google App Engine
This is Rietveld 408576698