Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_ast_test.dart

Issue 2728883004: Verify resynthesized elements by comparing text presentations. (Closed)
Patch Set: Ready for review. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
index 5efc290a0226eb3ba864f80da05b1ec645b2cb51..c59b4ed4ab36c9983e215d326aed41c7515209c5 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
@@ -6,6 +6,7 @@ library analyzer.test.src.summary.resynthesize_ast_test;
import 'dart:async';
+import 'element_text.dart';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/error/error.dart';
@@ -32,11 +33,19 @@ import '../task/strong/inferred_type_test.dart';
import 'resynthesize_common.dart';
import 'summary_common.dart';
+@reflectiveTest
+class ApplyReplacements {
+ test_applyReplacements() {
+ applyReplacements();
+ }
+}
+
main() {
defineReflectiveSuite(() {
defineReflectiveTests(ResynthesizeAstSpecTest);
defineReflectiveTests(ResynthesizeAstStrongTest);
- defineReflectiveTests(AstInferredTypeTest);
+// defineReflectiveTests(AstInferredTypeTest);
Paul Berry 2017/03/03 23:24:35 Uncomment before committing.
scheglov 2017/03/04 02:21:58 Done.
+ defineReflectiveTests(ApplyReplacements);
});
}
@@ -44,6 +53,9 @@ main() {
class AstInferredTypeTest extends AbstractResynthesizeTest
with _AstResynthesizeTestMixin, InferredTypeMixin {
@override
+ bool get isStrongMode => true;
+
+ @override
bool get mayCheckTypesOfLocals => false;
@override
@@ -686,13 +698,15 @@ var v = new C().m(1, b: 'bbb', c: 2.0);
@reflectiveTest
class ResynthesizeAstSpecTest extends _ResynthesizeAstTest {
@override
- AnalysisOptionsImpl createOptions() =>
- super.createOptions()..strongMode = false;
+ bool get isStrongMode => false;
}
@reflectiveTest
class ResynthesizeAstStrongTest extends _ResynthesizeAstTest {
@override
+ bool get isStrongMode => true;
+
+ @override
AnalysisOptionsImpl createOptions() =>
super.createOptions()..strongMode = true;
@@ -880,6 +894,8 @@ abstract class _AstResynthesizeTestMixinInterface {
abstract class _ResynthesizeAstTest extends ResynthesizeTest
with _AstResynthesizeTestMixin {
+ bool get isStrongMode;
+
@override
LibraryElementImpl checkLibrary(String text,
{bool allowErrors: false, bool dumpSummaries: false}) {
@@ -907,6 +923,10 @@ abstract class _ResynthesizeAstTest extends ResynthesizeTest
DartSdk createDartSdk() => AbstractContextTest.SHARED_MOCK_SDK;
@override
+ AnalysisOptionsImpl createOptions() =>
+ super.createOptions()..strongMode = isStrongMode;
+
+ @override
TestSummaryResynthesizer encodeDecodeLibrarySource(Source source) {
return _encodeLibrary(source);
}

Powered by Google App Engine
This is Rietveld 408576698