Verify resynthesized elements by comparing text presentations.

pkg/analyzer/test/src/summary/element_text.dart

Index: pkg/analyzer/test/src/summary/element_text.dart
diff --git a/pkg/analyzer/test/src/summary/element_text.dart b/pkg/analyzer/test/src/summary/element_text.dart
new file mode 100644
index 0000000000000000000000000000000000000000..dccaf7b390079436a738a6c02df390cd1e4330ed
--- /dev/null
+++ b/pkg/analyzer/test/src/summary/element_text.dart
@@ -0,0 +1,724 @@
+// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:io';
+
+import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/dart/ast/token.dart';
+import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/src/dart/element/element.dart';
+import 'package:analyzer/src/dart/element/type.dart';
+import 'package:analyzer/src/generated/source.dart';
+import 'package:analyzer/src/generated/utilities_dart.dart';
+import 'package:test/test.dart';
+
+const String _testPath =
+    '/Users/scheglov/Source/Dart/sdk.git/sdk/pkg/analyzer/test/src/summary/resynthesize_common.dart';

[Paul Berry, 2017/03/03 23:24:35]

Change to null before committing.

As I suggested earlier, you should be able to dynamically figure this out based
on Platform.script.  It's ok with me if you want to postpone this to a future
CL.

[scheglov, 2017/03/04 02:21:58]

I will change it to null for now.
Yes, initially I implemented scraping the file with changeElementText()
invocation from stack traces.
But it looked as over-engineering given that we have one, max two files to
update.

+
+final List<_Replacement> _replacements = [];
+
+String _testCode;
+LineInfo _testCodeLines;
+
+void applyReplacements() {
+  if (_testPath != null && _replacements.isNotEmpty) {
+    _replacements.sort((a, b) => b.offset - a.offset);
+    String newCode = _testCode;
+    _replacements.forEach((r) {
+      newCode =
+          newCode.substring(0, r.offset) + r.text + newCode.substring(r.end);
+    });
+    new File(_testPath).writeAsStringSync(newCode);
+  }
+}
+
+void checkElementText(LibraryElement library, String expected,
+    {bool updateExpectations: false, bool withOffsets: false}) {
+  var writer = new _ElementWriter(withOffsets: withOffsets);
+  writer.writeLibraryElement(library);
+  String actualText = writer.buffer.toString();
+  if (/*updateExpectations &&*/ actualText != expected) {

[Paul Berry, 2017/03/03 23:24:35]

Remove commented out text before committing.

[scheglov, 2017/03/04 02:21:58]

Done.

+    if (_testCode == null) {
+      _testCode = new File(_testPath).readAsStringSync();
+      _testCodeLines = new LineInfo.fromContent(_testCode);
+    }
+
+    try {
+      throw 42;
+    } catch (e, trace) {
+      String traceString = trace.toString();
+
+      // Assuming traceString contains "$_testPath:$invocationLine:$column",
+      // figure out the value of invocationLine.
+
+      print(traceString);
+      int testFilePathOffset = traceString.indexOf(_testPath);
+      expect(testFilePathOffset, isNonNegative);
+
+      // Sanity check: there must be ':' after the path.
+      expect(traceString[testFilePathOffset + _testPath.length], ':');
+
+      int lineOffset = testFilePathOffset + _testPath.length + ':'.length;
+      int invocationLine = int.parse(traceString.substring(
+          lineOffset, traceString.indexOf(':', lineOffset)));
+      int invocationOffset = _testCodeLines.getOffsetOfLine(invocationLine - 1);
+
+      const String rawStringPrefix = "r'''";
+      int expectationOffset =
+          _testCode.indexOf(rawStringPrefix, invocationOffset);
+
+      // Sanity check: there must be no other strings or blocks.
+      expect(_testCode.substring(invocationOffset, expectationOffset),
+          isNot(anyOf(contains("'"), contains('"'), contains('}'))));
+
+      expectationOffset += rawStringPrefix.length;
+      int expectationEnd = _testCode.indexOf("'''", expectationOffset);
+
+      _replacements.add(new _Replacement(
+          expectationOffset, expectationEnd, '\n' + actualText));
+    }
+  }
+
+  expect(actualText, expected);
+}
+
+class _ElementWriter {
+  final bool withOffsets;
+  final StringBuffer buffer = new StringBuffer();
+
+  _ElementWriter({this.withOffsets: false});
+
+  bool isDynamicType(DartType type) => type is DynamicTypeImpl;
+
+  bool isEnumElement(Element e) {
+    return e is ClassElement && e.isEnum;
+  }
+
+  void newLineIfNotEmpty() {
+    if (buffer.isNotEmpty) {
+      buffer.writeln();
+    }
+  }
+
+  void writeBodyModifiers(ExecutableElement e) {
+    if (e.isAsynchronous) {
+      expect(e.isSynchronous, isFalse);
+      buffer.write(' async');
+    }
+
+    if (e.isSynchronous && e.isGenerator) {
+      expect(e.isAsynchronous, isFalse);
+      buffer.write(' sync');
+    }
+
+    writeIf(e.isGenerator, '*');
+  }
+
+  void writeClassElement(ClassElement e) {
+    writeDocumentation(e);
+    writeMetadata(e, '', '\n');
+
+    writeIf(e.isAbstract, 'abstract ');
+
+    if (e.isEnum) {
+      buffer.write('enum ');
+    } else {
+      buffer.write('class ');
+    }
+
+    writeIf(e.isMixinApplication, 'alias ');
+
+    writeName(e);
+    writeTypeParameterElements(e.typeParameters);
+
+    if (e.supertype != null && e.supertype.displayName != 'Object' ||
+        e.mixins.isNotEmpty) {
+      buffer.write(' extends ');
+      writeType(e.supertype);
+    }
+
+    writeList(' with ', '', e.mixins, ', ', writeType);
+    writeList(' implements ', '', e.interfaces, ', ', writeType);
+
+    buffer.writeln(' {');
+
+    e.fields.forEach(writeFieldElement);
+    e.accessors.forEach(writePropertyAccessorElement);
+
+    if (e.isEnum) {
+      expect(e.constructors, isEmpty);
+    } else {
+      expect(e.constructors, isNotEmpty);
+    }
+
+    if (e.constructors.length == 1 &&
+        e.constructors[0].isSynthetic &&
+        e.mixins.isEmpty) {
+      expect(e.constructors[0].parameters, isEmpty);
+    } else {
+      e.constructors.forEach(writeConstructorElement);
+    }
+
+    e.methods.forEach(writeMethodElement);
+    buffer.writeln('}');
+  }
+
+  void writeConstructorElement(ConstructorElement e) {
+    writeDocumentation(e, '  ');
+    writeMetadata(e, '  ', '\n');
+
+    buffer.write('  ');
+
+    writeIf(e.isSynthetic, 'synthetic ');
+    writeIf(e.isExternal, 'external ');
+    writeIf(e.isConst, 'const ');
+    writeIf(e.isFactory, 'factory ');
+
+    buffer.write(e.enclosingElement.name);
+    if (e.name.isNotEmpty) {
+      buffer.write('.');
+      writeName(e);
+    }
+
+    writeParameterElements(e.parameters);
+
+    {
+      ConstructorElement redirected = e.redirectedConstructor;
+      if (redirected != null) {
+        buffer.write(' = ');
+        buffer.write(redirected.returnType);
+        if (redirected.name.isNotEmpty) {
+          buffer.write('.');
+          buffer.write(redirected.name);
+        }
+      }
+    }
+
+    if (e is ConstructorElementImpl) {
+      if (e.constantInitializers != null) {
+        writeList(' : ', '', e.constantInitializers, ', ', writeExpression);
+      }
+    }
+
+    expect(e.isAsynchronous, isFalse);
+    expect(e.isGenerator, isFalse);
+
+    buffer.writeln(';');
+  }
+
+  void writeDocumentation(Element e, [String prefix = '']) {
+    if (e.documentationComment != null) {
+      buffer.write(prefix);
+      buffer.writeln(e.documentationComment);
+    }
+  }
+
+  void writeExportElement(ExportElement e) {
+    writeMetadata(e, '', '\n');
+    buffer.write('export ');
+    writeUri(e, e.exportedLibrary.source);
+
+    e.combinators.forEach(writeNamespaceCombinator);
+
+    buffer.writeln(';');
+  }
+
+  void writeExpression(AstNode e) {
+    if (e is Annotation) {
+      buffer.write('@');
+      writeExpression(e.name);
+      if (e.constructorName != null) {
+        buffer.write('.');
+        writeExpression(e.constructorName);
+      }
+      if (e.arguments != null) {
+        writeList('(', ')', e.arguments.arguments, ', ', writeExpression,
+            includeEmpty: true);
+      }
+    } else if (e is AssertInitializer) {
+      buffer.write('assert(');
+      writeExpression(e.condition);
+      if (e.message != null) {
+        buffer.write(', ');
+        writeExpression(e.message);
+      }
+      buffer.write(')');
+    } else if (e is BinaryExpression) {
+      writeExpression(e.leftOperand);
+      buffer.write(' ');
+      buffer.write(e.operator.lexeme);
+      buffer.write(' ');
+      writeExpression(e.rightOperand);
+    } else if (e is BooleanLiteral) {
+      buffer.write(e.value);
+    } else if (e is ConditionalExpression) {
+      writeExpression(e.condition);
+      buffer.write(' ? ');
+      writeExpression(e.thenExpression);
+      buffer.write(' : ');
+      writeExpression(e.elseExpression);
+    } else if (e is ConstructorFieldInitializer) {
+      writeExpression(e.fieldName);
+      buffer.write(' = ');
+      writeExpression(e.expression);
+    } else if (e is ConstructorName) {
+      writeExpression(e.type);
+      if (e.name != null) {
+        buffer.write('.');
+        writeExpression(e.name);
+      }
+    } else if (e is DoubleLiteral) {
+      buffer.write(e.value);
+    } else if (e is InstanceCreationExpression) {
+      buffer.write(e.keyword.lexeme);
+      buffer.write(' ');
+      writeExpression(e.constructorName);
+      writeList('(', ')', e.argumentList.arguments, ', ', writeExpression,
+          includeEmpty: true);
+    } else if (e is IntegerLiteral) {
+      buffer.write(e.value);
+    } else if (e is InterpolationExpression) {
+      buffer.write(r'${');
+      writeExpression(e.expression);
+      buffer.write(r'}');
+    } else if (e is InterpolationString) {
+      buffer.write(e.value.replaceAll("'", r"\'"));
+    } else if (e is ListLiteral) {
+      if (e.constKeyword != null) {
+        buffer.write('const ');
+      }
+      if (e.typeArguments != null) {
+        writeList('<', '>', e.typeArguments.arguments, ', ', writeExpression);
+      }
+      writeList('[', ']', e.elements, ', ', writeExpression,
+          includeEmpty: true);
+    } else if (e is Label) {
+      writeExpression(e.label);
+      buffer.write(': ');
+    } else if (e is MapLiteral) {
+      if (e.constKeyword != null) {
+        buffer.write('const ');
+      }
+      if (e.typeArguments != null) {
+        writeList('<', '>', e.typeArguments.arguments, ', ', writeExpression);
+      }
+      writeList('{', '}', e.entries, ', ', writeExpression, includeEmpty: true);
+    } else if (e is MapLiteralEntry) {
+      writeExpression(e.key);
+      buffer.write(': ');
+      writeExpression(e.value);
+    } else if (e is NamedExpression) {
+      writeExpression(e.name);
+      buffer.write(e.expression);
+    } else if (e is NullLiteral) {
+      buffer.write('null');
+    } else if (e is PrefixExpression) {
+      buffer.write(e.operator.lexeme);
+      writeExpression(e.operand);
+    } else if (e is PrefixedIdentifier) {
+      writeExpression(e.prefix);
+      buffer.write('.');
+      writeExpression(e.identifier);
+    } else if (e is PropertyAccess) {
+      writeExpression(e.target);
+      buffer.write('.');
+      writeExpression(e.propertyName);
+    } else if (e is RedirectingConstructorInvocation) {
+      buffer.write('this');
+      if (e.constructorName != null) {
+        buffer.write('.');
+        writeExpression(e.constructorName);
+      }
+      writeList('(', ')', e.argumentList.arguments, ', ', writeExpression,
+          includeEmpty: true);
+    } else if (e is SimpleIdentifier) {
+      buffer.write(e.name);
+    } else if (e is SimpleStringLiteral) {
+      buffer.write("'");
+      buffer.write(e.value.replaceAll("'", r"\'"));
+      buffer.write("'");
+    } else if (e is StringInterpolation) {
+      buffer.write("'");
+      e.elements.forEach(writeExpression);
+      buffer.write("'");
+    } else if (e is SuperConstructorInvocation) {
+      buffer.write('super');
+      if (e.constructorName != null) {
+        buffer.write('.');
+        writeExpression(e.constructorName);
+      }
+      writeList('(', ')', e.argumentList.arguments, ', ', writeExpression,
+          includeEmpty: true);
+    } else if (e is SuperExpression) {
+      buffer.write('super');
+    } else if (e is SymbolLiteral) {
+      buffer.write('#');
+      writeList('', '', e.components, '.',
+          (Token token) => buffer.write(token.lexeme));
+    } else if (e is ThisExpression) {
+      buffer.write('this');
+    } else if (e is TypeName) {
+      writeExpression(e.name);
+      if (e.typeArguments != null) {
+        writeList('<', '>', e.typeArguments.arguments, ', ', writeExpression);
+      }
+    } else {
+      fail('Unsupported expression type: ${e.runtimeType}');
+    }
+  }
+
+  void writeFieldElement(FieldElement e) {
+    if (e.isSynthetic && !isEnumElement(e.enclosingElement)) {
+      return;
+    }
+
+    writeDocumentation(e, '  ');
+    writeMetadata(e, '  ', '\n');
+
+    buffer.write('  ');
+
+    writeIf(e.isStatic, 'static ');
+    writeIf(e is FieldElementImpl && e.isCovariant, 'covariant ');
+
+    writePropertyInducingElement(e);
+  }
+
+  void writeFunctionElement(FunctionElement e) {
+    writeIf(e.isExternal, 'external ');
+
+    writeType2(e.returnType);
+
+    writeName(e);
+
+    writeTypeParameterElements(e.typeParameters);
+    writeParameterElements(e.parameters);
+
+    writeBodyModifiers(e);
+
+    buffer.writeln(' {}');
+  }
+
+  void writeFunctionTypeAliasElement(FunctionTypeAliasElement e) {
+    writeDocumentation(e);
+    writeMetadata(e, '', '\n');
+
+    buffer.write('typedef ');
+    writeType2(e.returnType);
+
+    writeName(e);
+
+    writeTypeParameterElements(e.typeParameters);
+    writeParameterElements(e.parameters);
+
+    buffer.writeln(';');
+  }
+
+  void writeIf(bool flag, String str) {
+    if (flag) {
+      buffer.write(str);
+    }
+  }
+
+  void writeImportElement(ImportElement e) {
+    if (!e.isSynthetic) {
+      writeMetadata(e, '', '\n');
+      buffer.write('import ');
+      writeUri(e, e.importedLibrary.source);
+
+      writeIf(e.isDeferred, ' deferred');
+
+      if (e.prefix != null) {
+        buffer.write(' as ');
+        writeName(e.prefix);
+        if (withOffsets) {
+          buffer.write('(${e.prefixOffset})');
+        }
+      }
+
+      e.combinators.forEach(writeNamespaceCombinator);
+
+      buffer.writeln(';');
+    }
+  }
+
+  void writeLibraryElement(LibraryElement e) {
+    if (e.displayName != '') {
+      writeMetadata(e, '', '\n');
+      buffer.write('library ');
+      writeName(e);
+      buffer.writeln(';');
+    }
+
+    e.imports.forEach(writeImportElement);
+    e.exports.forEach(writeExportElement);
+    e.parts.forEach(writePartElement);
+
+    e.units.forEach(writeUnitElement);
+  }
+
+  void writeList<T>(String open, String close, List<T> items, String separator,
+      writeItem(T item),
+      {bool includeEmpty: false}) {
+    if (!includeEmpty && items.isEmpty) {
+      return;
+    }
+    buffer.write(open);
+    bool first = true;
+    for (T item in items) {
+      if (!first) {
+        buffer.write(separator);
+      }
+      writeItem(item);
+      first = false;
+    }
+    buffer.write(close);
+  }
+
+  void writeMetadata(Element e, String prefix, String separator) {
+    if (e.metadata.isNotEmpty) {
+      writeList(prefix, '', e.metadata, '$separator$prefix', (a) {
+        writeExpression((a as ElementAnnotationImpl).annotationAst);
+      });
+      buffer.write(separator);
+    }
+  }
+
+  void writeMethodElement(MethodElement e) {
+    writeDocumentation(e, '  ');
+    writeMetadata(e, '  ', '\n');
+
+    buffer.write('  ');
+
+    writeIf(e.isExternal, 'external ');
+    writeIf(e.isStatic, 'static ');
+
+    writeType2(e.returnType);
+
+    writeName(e);
+
+    writeTypeParameterElements(e.typeParameters);
+    writeParameterElements(e.parameters);
+
+    writeBodyModifiers(e);
+
+    if (e.isAbstract) {
+      buffer.writeln(';');
+    } else {
+      buffer.writeln(' {}');
+    }
+  }
+
+  void writeName(Element e) {
+    buffer.write(e.displayName);
+    if (withOffsets) {
+      buffer.write('(');
+      buffer.write(e.nameOffset);
+      buffer.write(')');
+    }
+  }
+
+  void writeNamespaceCombinator(NamespaceCombinator e) {
+    if (e is ShowElementCombinator) {
+      buffer.write(' show ');
+      buffer.write(e.shownNames.join(', '));
+    } else if (e is HideElementCombinator) {
+      buffer.write(' hide ');
+      buffer.write(e.hiddenNames.join(', '));
+    }
+  }
+
+  void writeParameterElement(ParameterElement e) {
+    String defaultValueSeparator;
+    Expression defaultValue =
+        e is DefaultParameterElementImpl ? e.constantInitializer : null;
+    String closeString;
+    ParameterKind kind = e.parameterKind;
+    if (kind == ParameterKind.REQUIRED) {
+      closeString = '';
+    } else if (kind == ParameterKind.POSITIONAL) {
+      buffer.write('[');
+      defaultValueSeparator = ' = ';
+      closeString = ']';
+    } else if (kind == ParameterKind.NAMED) {
+      buffer.write('{');
+      defaultValueSeparator = ': ';
+      closeString = '}';
+    } else {
+      fail('Unknown parameter kind: $kind');
+    }
+
+    writeMetadata(e, '', ' ');
+
+    writeIf(e.isCovariant, 'covariant ');
+    writeIf(e.isFinal, 'final ');
+
+    writeType2(e.type);
+
+    if (e is FieldFormalParameterElement) {
+      buffer.write('this.');
+    }
+
+    writeName(e);
+
+    if (defaultValue != null) {
+      buffer.write(defaultValueSeparator);
+      writeExpression(defaultValue);
+    }
+
+    buffer.write(closeString);
+  }
+
+  void writeParameterElements(List<ParameterElement> elements) {
+    writeList('(', ')', elements, ', ', writeParameterElement,
+        includeEmpty: true);
+  }
+
+  void writePartElement(CompilationUnitElement e) {
+    writeMetadata(e, '', '\n');
+    buffer.write('part ');
+    writeUri(e, e.source);
+    buffer.writeln(';');
+  }
+
+  void writePropertyAccessorElement(PropertyAccessorElement e) {
+    if (e.isSynthetic) {
+      return;
+    }
+
+    if (e.enclosingElement is ClassElement) {
+      writeDocumentation(e, '  ');
+      writeMetadata(e, '  ', '\n');
+
+      buffer.write('  ');
+
+      writeIf(e.isStatic, 'static ');
+    } else {
+      writeDocumentation(e);
+      writeMetadata(e, '', '\n');
+    }
+
+    writeIf(e.isExternal, 'external ');
+
+    writeType2(e.returnType);
+
+    if (e.isGetter) {
+      buffer.write('get ');
+    } else {
+      buffer.write('set ');
+    }
+
+    writeName(e);
+
+    if (e.isSetter || e.parameters.isNotEmpty) {
+      writeParameterElements(e.parameters);
+    }
+
+    expect(e.typeParameters, isEmpty);
+
+    expect(e.isSynchronous, isTrue);
+    expect(e.isAsynchronous, isFalse);
+    expect(e.isGenerator, isFalse);
+
+    if (e.isAbstract) {
+      buffer.writeln(';');
+    } else {
+      buffer.writeln(' {}');
+    }
+  }
+
+  void writePropertyInducingElement(PropertyInducingElement e) {
+    DartType type = e.type;
+    expect(type, isNotNull);
+
+    writeIf(e.isFinal, 'final ');
+    writeIf(e.isConst, 'const ');
+    writeType2(type);
+
+    writeName(e);
+
+    if (e is ConstVariableElement) {
+      Expression initializer = (e as ConstVariableElement).constantInitializer;
+      if (initializer != null) {
+        buffer.write(' = ');
+        writeExpression(initializer);
+      }
+    }
+
+    // TODO(scheglov) Paul: One of the things that was hardest to get right
+    // when resynthesizing the element model was the synthetic function for the
+    // initializer.  Can we write that out (along with its return type)?
+
+    buffer.writeln(';');
+  }
+
+  void writeTopLevelVariableElement(TopLevelVariableElement e) {
+    if (e.isSynthetic) {
+      return;
+    }
+    writeDocumentation(e);
+    writeMetadata(e, '', '\n');
+    writePropertyInducingElement(e);
+  }
+
+  void writeType(DartType type) {
+    if (type is InterfaceType) {
+      buffer.write(type.element.name);
+      if (type.element.typeParameters.isNotEmpty) {
+        writeList('<', '>', type.typeArguments, ', ', writeType);
+      }
+    } else {
+      buffer.write(type.displayName);
+    }
+  }
+
+  void writeType2(DartType type) {
+    writeType(type);
+    buffer.write(' ');
+  }
+
+  void writeTypeParameterElement(TypeParameterElement e) {
+    writeName(e);
+    if (e.bound != null) {
+      buffer.write(' extends ');
+      writeType(e.bound);
+    }
+  }
+
+  void writeTypeParameterElements(List<TypeParameterElement> elements) {
+    writeList('<', '>', elements, ', ', writeTypeParameterElement);
+  }
+
+  void writeUnitElement(CompilationUnitElement e) {
+    if (e.library.definingCompilationUnit != e) {
+      buffer.writeln('-' * 20);
+      buffer.writeln('unit: ${e.source.shortName}');
+      buffer.writeln();
+    }
+    e.functionTypeAliases.forEach(writeFunctionTypeAliasElement);
+    e.enums.forEach(writeClassElement);
+    e.types.forEach(writeClassElement);
+    e.topLevelVariables.forEach(writeTopLevelVariableElement);
+    e.accessors.forEach(writePropertyAccessorElement);
+    e.functions.forEach(writeFunctionElement);
+  }
+
+  void writeUri(UriReferencedElement e, Source source) {
+    String uri = e.uri ?? source.uri.toString();
+    buffer.write('\'$uri\'');
+    if (withOffsets) {
+      buffer.write('(');
+      buffer.write('${e.uriOffset}, ');
+      buffer.write('${e.uriEnd})');
+      buffer.write(')');
+    }
+  }
+}
+
+class _Replacement {
+  final int offset;
+  final int end;
+  final String text;
+  _Replacement(this.offset, this.end, this.text);
+}