Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2728883002: Adding LatencyInfo to mojom::Event. (Closed)

Created:
3 years, 9 months ago by mfomitchev
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tdresser+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding LatencyInfo to mojom::Event. Also updating the struct traits. BUG=686865 Review-Url: https://codereview.chromium.org/2728883002 Cr-Commit-Position: refs/heads/master@{#454380} Committed: https://chromium.googlesource.com/chromium/src/+/2e7ded925d16d7e4c7c406f15b887520d5c2a71f

Patch Set 1 #

Patch Set 2 : Adding handling for invalid event types. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -11 lines) Patch
M ui/events/mojo/event.mojom View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/mojo/event.typemap View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/mojo/event_struct_traits.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/mojo/event_struct_traits.cc View 1 6 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
mfomitchev
3 years, 9 months ago (2017-03-02 01:48:06 UTC) #2
mfomitchev
sadrul: Can you please take the first look?
3 years, 9 months ago (2017-03-02 01:48:32 UTC) #3
sadrul
lgtm
3 years, 9 months ago (2017-03-02 02:26:03 UTC) #4
mfomitchev
+tsepez@ for the security review
3 years, 9 months ago (2017-03-02 03:07:19 UTC) #6
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-02 17:14:18 UTC) #11
mfomitchev
On 2017/03/02 17:14:18, Tom Sepez wrote: > lgtm I've removed the dependency on https://codereview.chromium.org/2719223004/ and ...
3 years, 9 months ago (2017-03-02 20:30:35 UTC) #14
Tom Sepez
still lgtm
3 years, 9 months ago (2017-03-02 20:46:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728883002/20001
3 years, 9 months ago (2017-03-02 20:47:04 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 21:26:12 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2e7ded925d16d7e4c7c406f15b88...

Powered by Google App Engine
This is Rietveld 408576698