Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2728833003: Disabling NumTasksBeforeDetach in base_unittests due to flakiness (Closed)

Created:
3 years, 9 months ago by liaoyuke
Modified:
3 years, 9 months ago
Reviewers:
robliao, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling NumTasksBeforeDetach in base_unittests due to flakiness. This test failed on iOS-simulator twice during the past 30 runs. https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/15082 https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/15100 BUG=698046 TBR=fdoray@chromium.org Review-Url: https://codereview.chromium.org/2728833003 Cr-Commit-Position: refs/heads/master@{#454410} Committed: https://chromium.googlesource.com/chromium/src/+/76e94d0aa96fe99356b5009716739027fa4d0159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/task_scheduler/scheduler_worker_pool_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728833003/1
3 years, 9 months ago (2017-03-02 22:19:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/76e94d0aa96fe99356b5009716739027fa4d0159
3 years, 9 months ago (2017-03-02 22:37:19 UTC) #8
robliao
3 years, 9 months ago (2017-03-03 04:55:46 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698