Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Unified Diff: net/ssl/openssl_ssl_util.cc

Issue 2728823002: Remove redundant 3-SHAKE mitigation. (Closed)
Patch Set: typo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ssl/openssl_ssl_util.cc
diff --git a/net/ssl/openssl_ssl_util.cc b/net/ssl/openssl_ssl_util.cc
index c703a7166d500b0410d8a6d56497ce7ac7ded570..91c7908a5021fa2347d8139d4be96a96293c6985 100644
--- a/net/ssl/openssl_ssl_util.cc
+++ b/net/ssl/openssl_ssl_util.cc
@@ -98,13 +98,6 @@ int MapOpenSSLErrorSSL(uint32_t error_code) {
return ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY;
case SSL_R_SERVER_CERT_CHANGED:
return ERR_SSL_SERVER_CERT_CHANGED;
- case SSL_R_CERTIFICATE_VERIFY_FAILED:
- // The only way that the certificate verify callback can fail is if
- // the leaf certificate changed during a renegotiation.
- //
- // TODO(davidben): This check has since moved within BoringSSL. Remove the
- // Chromium-side machinery for it.
- return ERR_SSL_SERVER_CERT_CHANGED;
// SSL_R_SSLV3_ALERT_HANDSHAKE_FAILURE may be returned from the server after
// receiving ClientHello if there's no common supported cipher. Map that
// specific case to ERR_SSL_VERSION_OR_CIPHER_MISMATCH to match the NSS
« net/socket/ssl_client_socket_unittest.cc ('K') | « net/socket/ssl_server_socket_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698