Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 2728823002: Remove redundant 3-SHAKE mitigation. (Closed)
Patch Set: typo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_unittest.cc
diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc
index 8073af332975fc56b5d708f8dcdba2e6248afa29..a02d374c8714ee9f0e50441901d9c0320e7a94a3 100644
--- a/net/socket/ssl_client_socket_unittest.cc
+++ b/net/socket/ssl_client_socket_unittest.cc
@@ -1133,8 +1133,8 @@ TEST_F(SSLClientSocketTest, ConnectMismatched) {
#if defined(OS_WIN)
// Tests that certificates parsable by SSLClientSocket's internal SSL
-// implementation, but not X509Certificate are treated as fatal non-certificate
-// errors. This is regression test for https://crbug.com/91341.
+// implementation, but not X509Certificate are treated as fatal connection
+// errors. This is a regression test for https://crbug.com/91341.
TEST_F(SSLClientSocketTest, ConnectBadValidity) {
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_BAD_VALIDITY);
@@ -1145,10 +1145,6 @@ TEST_F(SSLClientSocketTest, ConnectBadValidity) {
EXPECT_THAT(rv, IsError(ERR_SSL_SERVER_CERT_BAD_FORMAT));
EXPECT_FALSE(IsCertificateError(rv));
-
- SSLInfo ssl_info;
- ASSERT_TRUE(sock_->GetSSLInfo(&ssl_info));
- EXPECT_FALSE(ssl_info.cert);
davidben 2017/03/07 00:19:34 Note this is a behavior change: before we'd get fa
}
#endif // defined(OS_WIN)

Powered by Google App Engine
This is Rietveld 408576698