Handles users rotating screen too early

ash/test/display_configuration_controller_test_api.h

Index: ash/test/display_configuration_controller_test_api.h
diff --git a/ash/test/display_configuration_controller_test_api.h b/ash/test/display_configuration_controller_test_api.h
new file mode 100644
index 0000000000000000000000000000000000000000..3da1d44f99646bb6604e7399a386cdbd6d359309
--- /dev/null
+++ b/ash/test/display_configuration_controller_test_api.h
@@ -0,0 +1,38 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_TEST_DISPLAY_CONFIGURATION_CONTROLLER_TEST_API_H_
+#define ASH_TEST_DISPLAY_CONFIGURATION_CONTROLLER_TEST_API_H_
+
+#include <stdint.h>
+
+#include "base/macros.h"
+
+namespace ash {
+class DisplayConfigurationController;
+class ScreenRotationAnimator;
+
+namespace test {
+
+// Accesses private data from a DisplayConfigurationController for testing.
+class DisplayConfigurationControllerTestApi {
+ public:
+  explicit DisplayConfigurationControllerTestApi(
+      DisplayConfigurationController* controller);
+
+  void DisableDisplayAnimator();
+  int DisplayScreenRotationAnimatorMapSize();
+  ScreenRotationAnimator* GetScreenRotationAnimatorForDisplay(

[bruthig, 2017/03/08 22:35:59]

nit: newline between declarations

[wutao, 2017/03/09 22:09:19]

Done.
When do we group functions together? For example accessor/mutator?

[bruthig, 2017/03/10 22:34:07]

I'm not sure if there's a concrete rule, but I would group functions together in
the following cases:
- They are all overrides from a specific parent class
- Sometimes getter/setters
- It's easier to document the functions as a group
- Possibly if they are all simple pass throughs from a TestAPI to a production
class (which may be the case here pending the debate on
GetScreenRotationAnimatorForDisplay()'s behavior).  But I would add a comment
above the grouping along the lines of '// Wrapper functions for
DisplayConfigurationController'.

[wutao, 2017/03/14 16:46:37]

Done.

+      int64_t display_id);
+
+ private:
+  DisplayConfigurationController* controller_;
+
+  DISALLOW_COPY_AND_ASSIGN(DisplayConfigurationControllerTestApi);
+};
+
+}  // namespace test
+}  // namespace ash
+
+#endif  // ASH_TEST_DISPLAY_CONFIGURATION_CONTROLLER_TEST_API_H_