Handles users rotating screen too early

ash/test/display_configuration_controller_test_api.cc

Index: ash/test/display_configuration_controller_test_api.cc
diff --git a/ash/test/display_configuration_controller_test_api.cc b/ash/test/display_configuration_controller_test_api.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4a0a003371d55690c85cf9a152d5f5f177601a8e
--- /dev/null
+++ b/ash/test/display_configuration_controller_test_api.cc
@@ -0,0 +1,32 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/test/display_configuration_controller_test_api.h"
+
+#include "ash/display/display_configuration_controller.h"
+
+namespace ash {
+namespace test {
+
+DisplayConfigurationControllerTestApi::DisplayConfigurationControllerTestApi(
+    DisplayConfigurationController* controller)
+    : controller_(controller) {}
+
+void DisplayConfigurationControllerTestApi::DisableDisplayAnimator() {
+  controller_->ResetAnimatorForTest();
+}
+
+int DisplayConfigurationControllerTestApi::
+    DisplayScreenRotationAnimatorMapSize() {
+  return controller_->display_animator_map_.size();
+}
+
+ScreenRotationAnimator*
+DisplayConfigurationControllerTestApi::GetScreenRotationAnimatorForDisplay(

[bruthig, 2017/03/08 22:35:59]

This function should probably be a raw accessor to the
controller_->display_animator_map_ and shouldn't have the side effect of
creating a ScreenRotationAnimator if one doesn't exist. i.e. this should
possibly return nullptr.

[wutao, 2017/03/09 22:09:19]

But in the test of ash/display/display_configuration_controller_unittest.cc, I
try to call this function to create a screen_rotation_animator, and test the
screen_rotation_animator can be deleted after rotation. I cannot return nullptr
here.

[bruthig, 2017/03/10 22:34:07]

Ack.

I wish there was an easier, less white-box way to perform that test but I can't
think of any good suggestions.

+    int64_t display_id) {
+  return controller_->GetScreenRotationAnimatorForDisplay(display_id);
+}
+
+}  // namespace test
+}  // namespace ash