Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2728773006: Settings reset prompt: do not show the prompt due to policy. (Closed)

Created:
3 years, 9 months ago by alito
Modified:
3 years, 9 months ago
Reviewers:
robertshield, csharp
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings reset prompt: do not show the prompt due to policy. During the experimental phase, simply do not show the reset prompt if a policy manages a setting the requires reset or if an extension that needs to be disabled is managed by policy. BUG= Review-Url: https://codereview.chromium.org/2728773006 Cr-Commit-Position: refs/heads/master@{#454558} Committed: https://chromium.googlesource.com/chromium/src/+/6a8242fa680b56f7052e1233e9472bf00ed1e27b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.cc View 3 chunks +64 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
alito
PTAL.
3 years, 9 months ago (2017-03-03 02:16:25 UTC) #2
csharp
lgtm
3 years, 9 months ago (2017-03-03 03:32:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728773006/1
3 years, 9 months ago (2017-03-03 09:19:19 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 10:15:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a8242fa680b56f7052e1233e947...

Powered by Google App Engine
This is Rietveld 408576698