chrome/browser/extensions/api/feedback_private/feedback_private_api.cc - Issue 2728773003: Make email field in Feedback app uneditable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2728773003: Make email field in Feedback app uneditable (Closed)

Patch Set: More nits Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc ('k') | chrome/browser/resources/feedback/css/feedback.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

index a0ca659846c19b4c086e9ea2ae009b63a3827302..bf70275158a6c8abbbb8fc8272dec24c61e226b2 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

@@ -166,9 +166,12 @@ ExtensionFunction::ResponseAction FeedbackPrivateGetStringsFunction::Run() {

dict->SetString(id, l10n_util::GetStringUTF16(idr))

SET_STRING("page-title", IDS_FEEDBACK_REPORT_PAGE_TITLE);

SET_STRING("additionalInfo", IDS_FEEDBACK_ADDITIONAL_INFO_LABEL);

+ SET_STRING("minimize-btn-label", IDS_FEEDBACK_MINIMIZE_BUTTON_LABEL);

+ SET_STRING("close-btn-label", IDS_FEEDBACK_CLOSE_BUTTON_LABEL);

SET_STRING("page-url", IDS_FEEDBACK_REPORT_URL_LABEL);

SET_STRING("screenshot", IDS_FEEDBACK_SCREENSHOT_LABEL);

SET_STRING("user-email", IDS_FEEDBACK_USER_EMAIL_LABEL);

+ SET_STRING("anonymous-user", IDS_FEEDBACK_ANONYMOUS_EMAIL_OPTION);

#if defined(OS_CHROMEOS)

if (arc::IsArcPlayStoreEnabledForProfile(

Profile::FromBrowserContext(browser_context()))) {