Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2728773003: Make email field in Feedback app uneditable (Closed)
Patch Set: More nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/feedback_private/feedback_private_api.h" 5 #include "chrome/browser/extensions/api/feedback_private/feedback_private_api.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 // static 159 // static
160 base::Closure* FeedbackPrivateGetStringsFunction::test_callback_ = NULL; 160 base::Closure* FeedbackPrivateGetStringsFunction::test_callback_ = NULL;
161 161
162 ExtensionFunction::ResponseAction FeedbackPrivateGetStringsFunction::Run() { 162 ExtensionFunction::ResponseAction FeedbackPrivateGetStringsFunction::Run() {
163 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue()); 163 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
164 164
165 #define SET_STRING(id, idr) \ 165 #define SET_STRING(id, idr) \
166 dict->SetString(id, l10n_util::GetStringUTF16(idr)) 166 dict->SetString(id, l10n_util::GetStringUTF16(idr))
167 SET_STRING("page-title", IDS_FEEDBACK_REPORT_PAGE_TITLE); 167 SET_STRING("page-title", IDS_FEEDBACK_REPORT_PAGE_TITLE);
168 SET_STRING("additionalInfo", IDS_FEEDBACK_ADDITIONAL_INFO_LABEL); 168 SET_STRING("additionalInfo", IDS_FEEDBACK_ADDITIONAL_INFO_LABEL);
169 SET_STRING("minimize-btn-label", IDS_FEEDBACK_MINIMIZE_BUTTON_LABEL);
170 SET_STRING("close-btn-label", IDS_FEEDBACK_CLOSE_BUTTON_LABEL);
169 SET_STRING("page-url", IDS_FEEDBACK_REPORT_URL_LABEL); 171 SET_STRING("page-url", IDS_FEEDBACK_REPORT_URL_LABEL);
170 SET_STRING("screenshot", IDS_FEEDBACK_SCREENSHOT_LABEL); 172 SET_STRING("screenshot", IDS_FEEDBACK_SCREENSHOT_LABEL);
171 SET_STRING("user-email", IDS_FEEDBACK_USER_EMAIL_LABEL); 173 SET_STRING("user-email", IDS_FEEDBACK_USER_EMAIL_LABEL);
174 SET_STRING("anonymous-user", IDS_FEEDBACK_ANONYMOUS_EMAIL_OPTION);
172 #if defined(OS_CHROMEOS) 175 #if defined(OS_CHROMEOS)
173 if (arc::IsArcPlayStoreEnabledForProfile( 176 if (arc::IsArcPlayStoreEnabledForProfile(
174 Profile::FromBrowserContext(browser_context()))) { 177 Profile::FromBrowserContext(browser_context()))) {
175 SET_STRING("sys-info", 178 SET_STRING("sys-info",
176 IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_AND_METRICS_CHKBOX_ARC); 179 IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_AND_METRICS_CHKBOX_ARC);
177 } else { 180 } else {
178 SET_STRING("sys-info", 181 SET_STRING("sys-info",
179 IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_AND_METRICS_CHKBOX); 182 IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_AND_METRICS_CHKBOX);
180 } 183 }
181 #else 184 #else
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 content::RecordAction( 358 content::RecordAction(
356 base::UserMetricsAction("Feedback.SrtPromptClosed")); 359 base::UserMetricsAction("Feedback.SrtPromptClosed"));
357 break; 360 break;
358 default: 361 default:
359 return RespondNow(Error("Invalid arugment.")); 362 return RespondNow(Error("Invalid arugment."));
360 } 363 }
361 return RespondNow(NoArguments()); 364 return RespondNow(NoArguments());
362 } 365 }
363 366
364 } // namespace extensions 367 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698