Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2728743003: Temporarily disabling JSON generation for Zone statistics to resolve flakiness in tests until a bet… (Closed)

Created:
3 years, 9 months ago by bkonyi
Modified:
3 years, 9 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temporarily disabling JSON generation for Zone statistics to resolve flakiness in tests until a better implementation is written. Issue #28885 (https://github.com/dart-lang/sdk/issues/28885). BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/6e02846b6da018bef753cd1eb8685ee577677682

Patch Set 1 #

Patch Set 2 : Removed code that was commented out in previous patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 1 2 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/thread.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/thread_test.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bkonyi
3 years, 9 months ago (2017-03-02 20:46:34 UTC) #2
bkonyi
3 years, 9 months ago (2017-03-02 20:46:35 UTC) #3
zra
Should we just delete this instead of commenting it out? We still have the CL ...
3 years, 9 months ago (2017-03-02 21:02:11 UTC) #4
bkonyi
On 2017/03/02 21:02:11, zra wrote: > Should we just delete this instead of commenting it ...
3 years, 9 months ago (2017-03-02 21:10:40 UTC) #5
bkonyi
On 2017/03/02 21:10:40, bkonyi wrote: > On 2017/03/02 21:02:11, zra wrote: > > Should we ...
3 years, 9 months ago (2017-03-02 21:26:30 UTC) #6
zra
lgtm Please add a related #<issue number> to the CL description, so we have a ...
3 years, 9 months ago (2017-03-02 22:09:12 UTC) #7
bkonyi
3 years, 9 months ago (2017-03-03 18:43:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6e02846b6da018bef753cd1eb8685ee577677682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698