Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: runtime/vm/thread_test.cc

Issue 2728743003: Temporarily disabling JSON generation for Zone statistics to resolve flakiness in tests until a bet… (Closed)
Patch Set: Removed code that was commented out in previous patch Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_test.cc
diff --git a/runtime/vm/thread_test.cc b/runtime/vm/thread_test.cc
index 74a97fdc9b0474eba08c5443660bbf468319f3c1..790596982a137901e5d30cdb0ee504d03dedde00 100644
--- a/runtime/vm/thread_test.cc
+++ b/runtime/vm/thread_test.cc
@@ -325,24 +325,9 @@ TEST_CASE(ManySimpleTasksWithZones) {
// Confirm all expected entries are in the JSON output.
for (intptr_t i = 0; i < kTaskCount + 1; i++) {
Thread* thread = threads[i];
- Zone* top_zone = thread->zone();
-
StackZone stack_zone(current_thread);
Zone* current_zone = current_thread->zone();
- // Check that all zones are present with correct sizes.
- while (top_zone != NULL) {
- char* zone_info_buf =
- OS::SCreate(current_zone,
- "\"type\":\"_Zone\","
- "\"capacity\":%" Pd
- ","
- "\"used\":%" Pd "",
- top_zone->CapacityInBytes(), top_zone->SizeInBytes());
- EXPECT_SUBSTRING(zone_info_buf, json);
- top_zone = top_zone->previous();
- }
-
// Check the thread exists and is the correct size.
char* thread_info_buf =
OS::SCreate(current_zone,
« no previous file with comments | « runtime/vm/thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698