Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 2728743002: Change transport security state generator logging destination. (Closed)

Created:
3 years, 9 months ago by martijnc
Modified:
3 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change transport security state generator logging destination. Change the logging destination to logging::LOG_TO_SYSTEM_DEBUG_LOG for all platforms. On windows the default is LOG_TO_FILE but that fails here (program exits with error code 3). This aligns the generator with the other net/tools tools. BUG=595493 Review-Url: https://codereview.chromium.org/2728743002 Cr-Commit-Position: refs/heads/master@{#454070} Committed: https://chromium.googlesource.com/chromium/src/+/56daed9bb730e001dab5923e28fc83665e3e9a92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/tools/transport_security_state_generator/transport_security_state_generator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
martijnc
It seems the default logging destination on Windows doesn't work here. This CL changes the ...
3 years, 9 months ago (2017-03-01 22:02:38 UTC) #2
Ryan Sleevi
lgtm
3 years, 9 months ago (2017-03-01 22:04:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728743002/1
3 years, 9 months ago (2017-03-01 22:05:31 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 22:27:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56daed9bb730e001dab5923e28fc...

Powered by Google App Engine
This is Rietveld 408576698