Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2728733002: Revert of [Autofill] Split server card data and metadata updates. (Closed)

Created:
3 years, 9 months ago by sebsg
Modified:
3 years, 9 months ago
Reviewers:
Mathieu
CC:
Jared Saul, jiahuiguo1, chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Autofill] Split server card data and metadata updates. (patchset #3 id:60001 of https://codereview.chromium.org/2719723002/ ) Reason for revert: Breaks the Wallet address conversion feature Original issue's description: > This caused a bug where the use_date would be reset when adding a new server card. > The metadata should not be updated in this case. > > BUG=696365 > > Review-Url: https://codereview.chromium.org/2719723002 > Cr-Commit-Position: refs/heads/master@{#453210} > Committed: https://chromium.googlesource.com/chromium/src/+/464db18fe97e6e7f73667db90a761239447d8e97 TBR=mathp@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=696365 Review-Url: https://codereview.chromium.org/2728733002 Cr-Commit-Position: refs/heads/master@{#454032} Committed: https://chromium.googlesource.com/chromium/src/+/76cd49480c8acf3a4ade533c0b9988b33c40ce89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -20 lines) Patch
M components/autofill/core/browser/autofill_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 6 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sebsg
Created Revert of [Autofill] Split server card data and metadata updates.
3 years, 9 months ago (2017-03-01 20:10:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728733002/1
3 years, 9 months ago (2017-03-01 20:10:53 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 21:19:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76cd49480c8acf3a4ade533c0b99...

Powered by Google App Engine
This is Rietveld 408576698