Cleaned up code duplication in -[CRWWebController goToItemAtIndex:].

Cleaned up code duplication in -[CRWWebController goToItemAtIndex:].

Moved updateDesktopUserAgentForEntry:fromEntry: out of conditional
blocks, because the calls order does not matter as long as |toEntry| is
correct.

Removed unnecessary webWillFinishHistoryNavigationFromEntry: call. For
same-document navigations Tab gets webState:didFinishNavigation: call
and for different-document navigations Tab gets
webState:didStartProvisionalNavigationForURL:. Both calls update the
toolbar, which is the only thing done in
webWillFinishHistoryNavigationFromEntry:.

BUG=684098
Review-Url: https://codereview.chromium.org/2728723002
Cr-Commit-Position: refs/heads/master@{#454079}
Committed: https://chromium.googlesource.com/chromium/src/+/9b2fb40242a52cf1cf25b14eff6f095432c7bb81

[Eugene But (OOO till 7-30), 2017-03-01 19:50:30]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 19:51:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 20:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 20:07:38]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-03-01 22:27:38]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[kkhorimoto, 2017-03-01 22:41:26]

lgtm

[Eugene But (OOO till 7-30), 2017-03-01 22:47:08]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:47:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:53:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488408428094130, "parent_rev":
"d348bbd2a92cc6e784868019bc2a1822e2437c59", "commit_rev":
"9b2fb40242a52cf1cf25b14eff6f095432c7bb81"}

[commit-bot: I haz the power, 2017-03-01 22:53:49]

Description was changed from

==========
Cleaned up code duplication in -[CRWWebController goToItemAtIndex:].

Moved updateDesktopUserAgentForEntry:fromEntry: out of conditional
blocks, because the calls order does not matter as long as |toEntry| is
correct.

Removed unnecessary webWillFinishHistoryNavigationFromEntry: call. For
same-document navigations Tab gets webState:didFinishNavigation: call
and for different-document navigations Tab gets
webState:didStartProvisionalNavigationForURL:. Both calls update the
toolbar, which is the only thing done in
webWillFinishHistoryNavigationFromEntry:.

BUG=684098
==========

to

==========
Cleaned up code duplication in -[CRWWebController goToItemAtIndex:].

Moved updateDesktopUserAgentForEntry:fromEntry: out of conditional
blocks, because the calls order does not matter as long as |toEntry| is
correct.

Removed unnecessary webWillFinishHistoryNavigationFromEntry: call. For
same-document navigations Tab gets webState:didFinishNavigation: call
and for different-document navigations Tab gets
webState:didStartProvisionalNavigationForURL:. Both calls update the
toolbar, which is the only thing done in
webWillFinishHistoryNavigationFromEntry:.

BUG=684098

Review-Url: https://codereview.chromium.org/2728723002
Cr-Commit-Position: refs/heads/master@{#454079}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b2fb40242a52cf1cf25b14eff6f...
==========

[commit-bot: I haz the power, 2017-03-01 22:53:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b2fb40242a52cf1cf25b14eff6f...