Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Issue 2728713003: [eme] Simplify parsing of contentTypes (Closed)

Created:
3 years, 9 months ago by jrummell
Modified:
3 years, 9 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, blink-reviews, haraken, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[eme] Simplify parsing of contentTypes Now that ParsedContentType does case-insensitive parameter lookups (http://crbug.com/689731), use it to extract the type and codecs parameter. BUG=605661 TEST=existing case-insensitive EME tests pass Review-Url: https://codereview.chromium.org/2728713003 Cr-Commit-Position: refs/heads/master@{#454664} Committed: https://chromium.googlesource.com/chromium/src/+/699c0840f87b9839b04a7cca2805d890609e5cf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jrummell
PTAL.
3 years, 9 months ago (2017-03-02 01:19:27 UTC) #2
xhwang
For the record, can you update CL description to refer to the ParsedContentType change? e.g. ...
3 years, 9 months ago (2017-03-03 18:26:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728713003/1
3 years, 9 months ago (2017-03-03 19:10:23 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 20:46:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/699c0840f87b9839b04a7cca2805...

Powered by Google App Engine
This is Rietveld 408576698