Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2728713002: Fix msan failure on WebPointerProperties. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
mustaq, Rick Byers
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix msan failure on WebPointerProperties. Caused by change https://chromium.googlesource.com/chromium/src/+/2fe7948 the movementX/Y fields moved from a memset inialized struct to a struct that wasn't memset. The fields need to be initialized in the ctor of this object. BUG=697177 TBR=rbyers@chromium.org Review-Url: https://codereview.chromium.org/2728713002 Cr-Commit-Position: refs/heads/master@{#454024} Committed: https://chromium.googlesource.com/chromium/src/+/c28d835116eda137a4c299b9b610df32fc5075a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/public/platform/WebPointerProperties.h View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
dtapuska
3 years, 9 months ago (2017-03-01 19:02:16 UTC) #2
mustaq
lgtm
3 years, 9 months ago (2017-03-01 20:29:39 UTC) #9
dtapuska
On 2017/03/01 20:29:39, mustaq wrote: > lgtm TBR'ng rbyers@ due to simple change and the ...
3 years, 9 months ago (2017-03-01 20:33:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728713002/1
3 years, 9 months ago (2017-03-01 20:34:31 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c28d835116eda137a4c299b9b610df32fc5075a4
3 years, 9 months ago (2017-03-01 20:41:30 UTC) #15
Rick Byers
3 years, 9 months ago (2017-03-02 15:19:56 UTC) #16
Message was sent while issue was closed.
On 2017/03/01 20:33:33, dtapuska wrote:
> On 2017/03/01 20:29:39, mustaq wrote:
> > lgtm
> 
> TBR'ng rbyers@ due to simple change and the fact the msan bot is red due to
> this.

retroactive LGTM - thanks for not blocking on me

Powered by Google App Engine
This is Rietveld 408576698