Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2728683007:
Fix crash when de-referencing the WebFrameWidget. (Closed)
DescriptionFix crash when de-referencing the WebFrameWidget.
This change adds a null check before de-referencing the main frame. This
fixes a race where the main frame is swapped while there is a in-flight
request to lock the mouse.
BUG=697421
Review-Url: https://codereview.chromium.org/2728683007
Cr-Commit-Position: refs/heads/master@{#455027}
Committed: https://chromium.googlesource.com/chromium/src/+/4d8296ca0eee12ba5876ea0cafde76e0f8359981
Patch Set 1 #
Total comments: 2
Patch Set 2 : add comments #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by lfg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lfg@chromium.org changed reviewers: + dcheng@chromium.org
Daniel, please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2728683007/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/2728683007/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/web/WebViewImpl.cpp:2549: if (mainFrameImpl()) Please add some comments here too to document the race.
The CQ bit was checked by lfg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
https://codereview.chromium.org/2728683007/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/2728683007/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/web/WebViewImpl.cpp:2549: if (mainFrameImpl()) On 2017/03/03 23:57:24, dcheng wrote: > Please add some comments here too to document the race. Done.
The CQ bit was checked by lfg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2728683007/#ps20001 (title: "add comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by lfg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488853905558770,
"parent_rev": "3e9cb9dc430aa94a9b10c268c620a4ef8a24a8d9", "commit_rev":
"4d8296ca0eee12ba5876ea0cafde76e0f8359981"}
Message was sent while issue was closed.
Description was changed from ========== Fix crash when de-referencing the WebFrameWidget. This change adds a null check before de-referencing the main frame. This fixes a race where the main frame is swapped while there is a in-flight request to lock the mouse. BUG=697421 ========== to ========== Fix crash when de-referencing the WebFrameWidget. This change adds a null check before de-referencing the main frame. This fixes a race where the main frame is swapped while there is a in-flight request to lock the mouse. BUG=697421 Review-Url: https://codereview.chromium.org/2728683007 Cr-Commit-Position: refs/heads/master@{#455027} Committed: https://chromium.googlesource.com/chromium/src/+/4d8296ca0eee12ba5876ea0cafde... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4d8296ca0eee12ba5876ea0cafde... |
