[MD settings] controlled by extension icon on default font size

[MD settings] controlled by extension icon on default font size

This CL adds indicators for dropdown menus that are controled by an
extension. An example of which is the default font size dropdown.

BUG=693302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2728683004
Cr-Commit-Position: refs/heads/master@{#455246}
Committed: https://chromium.googlesource.com/chromium/src/+/95dec86ee4d37aaef13df66737e46a93c669907a

[dschuyler, 2017-03-02 02:32:34]

Description was changed from

==========
[MD settings] controlled by extension icon on default font size

This CL adds indicators for dropdown menus that are controled by an
extension. An example of which is the default font size dropdown.

BUG=693302
==========

to

==========
[MD settings] controlled by extension icon on default font size

This CL adds indicators for dropdown menus that are controled by an
extension. An example of which is the default font size dropdown.

BUG=693302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-03-02 02:32:37]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 02:34:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-02 02:34:20]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 02:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 02:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 02:51:46]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dschuyler, 2017-03-02 19:19:52]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 19:20:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-02 19:25:14]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 19:25:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-02 19:25:51]

Patchset #1 (id:1) has been deleted

[dschuyler, 2017-03-02 19:25:59]

Patchset #1 (id:20001) has been deleted

[dschuyler, 2017-03-02 19:26:07]

Patchset #1 (id:40001) has been deleted

[dschuyler, 2017-03-02 19:31:36]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[dschuyler, 2017-03-02 19:31:37]

https://codereview.chromium.org/2728683004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_dropdown_menu.html
(right):

https://codereview.chromium.org/2728683004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.html:20:
-webkit-margin-start: var(--checkbox-spacing);
It could be argued that --checkbox-spacing should get a different name since
it's used outside of checkboxes (here and elsewhere). It's really more of a
generic horizontal spacing within a control (such as a checkbox). If desired,
I'd like to do that post this CL.

Other uses:
https://cs.chromium.org/search/?q=checkbox-spacing+file:src/chrome&type=cs

[commit-bot: I haz the power, 2017-03-02 20:32:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 20:32:21]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-03-03 21:26:27]

lgtm thanks

https://codereview.chromium.org/2728683004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_dropdown_menu.html
(right):

https://codereview.chromium.org/2728683004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.html:20:
-webkit-margin-start: var(--checkbox-spacing);
On 2017/03/02 19:31:37, dschuyler wrote:
> It could be argued that --checkbox-spacing should get a different name since
> it's used outside of checkboxes (here and elsewhere). It's really more of a
> generic horizontal spacing within a control (such as a checkbox). If desired,
> I'd like to do that post this CL.
> 
> Other uses:
> https://cs.chromium.org/search/?q=checkbox-spacing+file:src/chrome&type=cs

Sounds good, in followup CL sounds good.

[dschuyler, 2017-03-06 21:21:17]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-03-06 21:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 21:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 21:25:07]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[dschuyler, 2017-03-06 22:08:13]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 22:08:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 23:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 23:06:58]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[dschuyler, 2017-03-07 21:50:23]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 21:51:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-07 21:57:35]

Patchset #3 (id:100001) has been deleted

[dschuyler, 2017-03-07 21:58:03]

The CQ bit was unchecked by dschuyler@chromium.org

[dschuyler, 2017-03-07 21:58:09]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2017-03-07 21:58:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2728683004/#ps80001
(title: "merge with master")

[commit-bot: I haz the power, 2017-03-07 21:59:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:16:36]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488923889096810,
"parent_rev": "efcd0c614acac68022267a2eb1af6519353906fb", "commit_rev":
"95dec86ee4d37aaef13df66737e46a93c669907a"}

[commit-bot: I haz the power, 2017-03-07 22:17:14]

Description was changed from

==========
[MD settings] controlled by extension icon on default font size

This CL adds indicators for dropdown menus that are controled by an
extension. An example of which is the default font size dropdown.

BUG=693302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] controlled by extension icon on default font size

This CL adds indicators for dropdown menus that are controled by an
extension. An example of which is the default font size dropdown.

BUG=693302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2728683004
Cr-Commit-Position: refs/heads/master@{#455246}
Committed:
https://chromium.googlesource.com/chromium/src/+/95dec86ee4d37aaef13df66737e4...
==========

[commit-bot: I haz the power, 2017-03-07 22:17:16]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/95dec86ee4d37aaef13df66737e4...