Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2728633003: (Android) Using TestCase instead of deprecated InstrumentationTestCase (Closed)

Created:
3 years, 9 months ago by marcin
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, android-webview-reviews_chromium.org, asanka, browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dominickn+watch_chromium.org, jam, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Android) Using TestCase instead of deprecated InstrumentationTestCase In some cases deprecated InstrumentationTestCase can be replaced with more generic TestCase. Each test was ran after change (to satisfy boliu's comment, that replacement "is more complicated than a simple search and replace."). BUG=697653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -47 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwLayoutSizerTest.java View 1 chunk +3 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwScrollOffsetManagerTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CleanupReferenceTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimationTest.java View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadUtilsTest.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/IntentWithGesturesHandlerTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryAdapterTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGeneratorTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactoryTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omaha/StringSanitizerTest.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/AsyncTabCreationParamsManagerTest.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/util/HashUtilTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/EncodeHtmlDataUriTest.java View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaResourceGetterTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/crypto/CipherFactoryTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/CursorAnchorInfoControllerTest.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
marcin
3 years, 9 months ago (2017-03-01 23:26:05 UTC) #3
gone
Tests -> jbudorick@
3 years, 9 months ago (2017-03-01 23:27:59 UTC) #9
boliu
not lgtm this is more complicated than a simple search and replace. InstrumentationTestCase provides a ...
3 years, 9 months ago (2017-03-01 23:29:23 UTC) #11
marcin
On 2017/03/01 23:29:23, boliu wrote: > not lgtm > > this is more complicated than ...
3 years, 9 months ago (2017-03-01 23:31:15 UTC) #12
marcin
3 years, 9 months ago (2017-03-01 23:34:03 UTC) #18
marcin
On 2017/03/01 23:34:03, marcin wrote: -boliu
3 years, 9 months ago (2017-03-01 23:48:40 UTC) #20
jbudorick
On 2017/03/01 23:29:23, boliu wrote: > not lgtm > > this is more complicated than ...
3 years, 9 months ago (2017-03-02 01:06:21 UTC) #22
gone
Removing a reviewer who has "not lgtmed" a CL doesn't mean that you can just ...
3 years, 9 months ago (2017-03-02 01:10:19 UTC) #23
the real yoland
An example of how this would be converted: https://codereview.chromium.org/2726003002
3 years, 9 months ago (2017-03-02 02:02:25 UTC) #25
marcin
On 2017/03/02 02:02:25, the real yoland wrote: > An example of how this would be ...
3 years, 9 months ago (2017-03-02 02:12:40 UTC) #26
marcin
On 2017/03/02 02:12:40, marcin wrote: > On 2017/03/02 02:02:25, the real yoland wrote: > > ...
3 years, 9 months ago (2017-03-02 02:14:21 UTC) #27
boliu
On 2017/03/02 02:14:21, marcin wrote: > On 2017/03/02 02:12:40, marcin wrote: > > On 2017/03/02 ...
3 years, 9 months ago (2017-03-02 02:26:30 UTC) #28
marcin
3 years, 9 months ago (2017-03-02 02:37:38 UTC) #29
On 2017/03/02 02:26:30, boliu wrote:
> On 2017/03/02 02:14:21, marcin wrote:
> > On 2017/03/02 02:12:40, marcin wrote:
> > > On 2017/03/02 02:02:25, the real yoland wrote:
> > > > An example of how this would be converted:
> > > > https://codereview.chromium.org/2726003002
> > > 
> > > I agree, that with some tests we need full conversion...
> > > but when extending TestCase is sometimes enough, can't we use this?
> > 
> > ...in other words - does dropping my CL has got any technical explanation?
> 
> We are also going from junit3 to junit4, meaning we will stop using TestCase
> altogether. So this CL does nothing to help with that effort.

and this should be mentioned first instead of suggesting, that patch was made
just with copy-paste and without any compiling and functional checking

Powered by Google App Engine
This is Rietveld 408576698