Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2726003002: Auto convert base javatests in content shell apk to JUnit4 (Closed)

Created:
3 years, 9 months ago by the real yoland
Modified:
3 years, 9 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Auto convert base javatests in content shell apk to JUnit4 Use Auto change script to convert all javatests in base. For more information, check out src/testing/android/docs/junit4.md BUG=640116 Review-Url: https://codereview.chromium.org/2726003002 Cr-Commit-Position: refs/heads/master@{#455522} Committed: https://chromium.googlesource.com/chromium/src/+/73bf58c68854758f64cd611980687138089bfd0b

Patch Set 1 #

Patch Set 2 : Add manifest #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -299 lines) Patch
M base/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/AdvancedMockContextTest.java View 1 4 chunks +17 lines, -10 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/ApiCompatibilityUtilsTest.java View 1 3 chunks +42 lines, -25 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/CommandLineTest.java View 4 chunks +38 lines, -29 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/EarlyTraceEventTest.java View 8 chunks +40 lines, -27 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/LocaleUtilsTest.java View 4 chunks +61 lines, -49 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/ObserverListTest.java View 8 chunks +98 lines, -86 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/metrics/RecordHistogramTest.java View 7 chunks +83 lines, -73 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
the real yoland
migrated all tests except for CommandLineInitUtilTest
3 years, 9 months ago (2017-03-02 02:20:49 UTC) #8
the real yoland
On 2017/03/02 at 02:20:49, the real yoland wrote: > migrated all tests except for CommandLineInitUtilTest ...
3 years, 9 months ago (2017-03-02 02:21:30 UTC) #9
boliu
content lgtm
3 years, 9 months ago (2017-03-02 02:27:20 UTC) #10
the real yoland
add +agrieve for base/ review
3 years, 9 months ago (2017-03-08 18:21:22 UTC) #15
agrieve
On 2017/03/08 18:21:22, the real yoland wrote: > add +agrieve for base/ review lgtm
3 years, 9 months ago (2017-03-08 18:28:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726003002/40001
3 years, 9 months ago (2017-03-08 18:40:45 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 20:14:53 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/73bf58c68854758f64cd61198068...

Powered by Google App Engine
This is Rietveld 408576698