Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2728563003: Revert of fix quick unlock config in options (Closed)

Created:
3 years, 9 months ago by Yuta Kitamura
Modified:
3 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of fix quick unlock config in options (patchset #8 id:140001 of https://codereview.chromium.org/2691943005/ ) Reason for revert: This caused the following test to fail on ChromiumOS debug bots. I've confirmed reverting this patch would fix the errors on my local environment. PolicyPrefIndicatorTestInstance/PolicyPrefIndicatorTest.CheckPolicyIndicators/26 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 Original issue's description: > This CL is trying to fix 2 issues: > 1. Quick unlock configuration in options are importing polymer elements(lock_screen.html) created in settings, that includes importing all the elements that lock_screen.html depends on. So if there's new polymer elements imported in lock_screen.html, options wouldn't know where to find them, thus not able to load the lock_screen element. This CL makes options page know these newly added elements. > > 2. Trying to pre-load polymer elements in options page for better user experience. > > BUG=679795 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2691943005 > Cr-Commit-Position: refs/heads/master@{#453733} > Committed: https://chromium.googlesource.com/chromium/src/+/a7b35b6e3091d62218d6093633589997036e3b98 TBR=sammiequon@chromium.org,jdufault@chromium.org,dbeam@chromium.org,xiaoyinh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679795 Review-Url: https://codereview.chromium.org/2728563003 Cr-Commit-Position: refs/heads/master@{#453891} Committed: https://chromium.googlesource.com/chromium/src/+/02b583cc874be794a9772f8b13230ab480058839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -92 lines) Patch
M chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js View 2 chunks +0 lines, -16 lines 0 comments Download
D chrome/browser/resources/options/i18n_setup.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options_resources.grd View 2 chunks +58 lines, -32 lines 0 comments Download
M chrome/browser/resources/settings/people_page/lock_screen.js View 4 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Yuta Kitamura
Created Revert of fix quick unlock config in options
3 years, 9 months ago (2017-03-01 09:11:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728563003/1
3 years, 9 months ago (2017-03-01 09:11:54 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 09:13:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02b583cc874be794a9772f8b1323...

Powered by Google App Engine
This is Rietveld 408576698