Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: src/debug/interface-types.h

Issue 2728563002: [inspector] added type of break location into getPossibleBreakpoints output (Closed)
Patch Set: a Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/interface-types.h
diff --git a/src/debug/interface-types.h b/src/debug/interface-types.h
index b86986dee4c30719406d393253706c96a5129985..82df35ae75f301bdceafcb893f1be771bbb10d05 100644
--- a/src/debug/interface-types.h
+++ b/src/debug/interface-types.h
@@ -50,6 +50,7 @@ struct WasmDisassemblyOffsetTableEntry {
int line;
int column;
};
+
struct WasmDisassembly {
using OffsetTable = std::vector<WasmDisassemblyOffsetTableEntry>;
WasmDisassembly() {}
@@ -71,6 +72,28 @@ enum PromiseDebugActionType {
kDebugDidHandle,
};
+class V8_EXPORT_PRIVATE BreakLocation {
dgozman 2017/03/01 22:10:47 Let's inherit from Location?
kozy 2017/03/01 23:14:13 Done.
+ public:
+ BreakLocation(const Location& location, bool is_call, bool is_return,
+ bool is_debugger_statement)
+ : location_(location),
+ is_call_(is_call),
+ is_return_(is_return),
+ is_debugger_statement_(is_debugger_statement) {}
+
+ const Location& GetLocation() const { return location_; }
+ Location& GetLocation() { return location_; }
+ bool IsCall() { return is_call_; }
+ bool IsReturn() { return is_return_; }
+ bool IsDebuggerStatement() { return is_debugger_statement_; }
+
+ private:
+ Location location_;
+ bool is_call_;
+ bool is_return_;
+ bool is_debugger_statement_;
+};
+
} // namespace debug
} // namespace v8

Powered by Google App Engine
This is Rietveld 408576698