Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2728543002: DevTools: refactor Common.Renderer for DOM nodes (Closed)
Patch Set: fixup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
index 38d3a035cb916dedd594f0a996c133a68efd5169..200e4985ae40c5a4348fd9e9ca7155668641b73d 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
@@ -1595,19 +1595,13 @@ Elements.ElementsTreeOutline.Renderer = class {
* @param {function(!Error)} reject
*/
function renderPromise(resolve, reject) {
- if (object instanceof SDK.DOMNode) {
+ if (object instanceof SDK.DOMNode)
onNodeResolved(/** @type {!SDK.DOMNode} */ (object));
- } else if (object instanceof SDK.DeferredDOMNode) {
+ else if (object instanceof SDK.DeferredDOMNode)
(/** @type {!SDK.DeferredDOMNode} */ (object)).resolve(onNodeResolved);
- } else if (object instanceof SDK.RemoteObject) {
- var domModel = SDK.DOMModel.fromTarget((/** @type {!SDK.RemoteObject} */ (object)).runtimeModel().target());
- if (domModel)
- domModel.pushObjectAsNodeToFrontend(object, onNodeResolved);
- else
- reject(new Error('No dom model for given JS object target found.'));
- } else {
+ else
reject(new Error('Can\'t reveal not a node.'));
- }
+
/**
* @param {?SDK.DOMNode} node

Powered by Google App Engine
This is Rietveld 408576698