third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js - Issue 2728543002: DevTools: refactor Common.Renderer for DOM nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2728543002: DevTools: refactor Common.Renderer for DOM nodes (Closed)

Patch Set: fixup Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

index 6d0eeeade99b037cbff67544139e498c405220b2..0d316a378b6eb35cbc68c705685b58197b9e951b 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

@@ -1030,7 +1030,7 @@ Elements.ElementsPanel.DOMNodeRevealer = class {

} else if (node instanceof SDK.RemoteObject) {

var domModel = SDK.DOMModel.fromTarget(/** @type {!SDK.RemoteObject} */ (node).runtimeModel().target());

if (domModel)

- domModel.pushObjectAsNodeToFrontend(node, onNodeResolved);

+ domModel.pushObjectAsNodeToFrontend(node).then(onNodeResolved);

else

reject(new Error('Could not resolve a node to reveal.'));

} else {