Log Android LibraryLoader failures

Log Android LibraryLoader failures

We recently had a build break that removed a library dependency from Chrome, but was still required by Android.  Our LibraryLoader attempted to load it and failed, but didn't actually output the failing library.  This made it harder to track down the root cause than it should have been.

Make a Log.e() call for LibraryLoader failures that prints out the
library that we can't load.

BUG=

Review-Url: https://codereview.chromium.org/2728513003
Cr-Commit-Position: refs/heads/master@{#454339}
Committed: https://chromium.googlesource.com/chromium/src/+/8c9deb74cf4f697cb0f6bdb589f04085e8d73e63

[David Trainor- moved to gerrit, 2017-03-01 23:06:53]

dtrainor@chromium.org changed reviewers:
+ nyquist@chromium.org

[David Trainor- moved to gerrit, 2017-03-01 23:06:54]

ptal thanks!

[nyquist, 2017-03-01 23:10:28]

lgtm, but could you expand the CL description?

I.e.:
- What happened before this CL? (we didn't tell anyone about it)
- Why was that bad? (it was hard to figure out what went wrong)
- How does this CL make it better? (that you've already explained in the current
description)

[David Trainor- moved to gerrit, 2017-03-02 18:41:29]

Description was changed from

==========
Log Android LibraryLoader failures

Make a Log.e() call for LibraryLoader failures that prints out the
library that we can't load.

BUG=
==========

to

==========
Log Android LibraryLoader failures

We recently had a build break that removed a library dependency from Chrome, but
was still required by Android.  Our LibraryLoader attempted to load it and
failed, but didn't actually output the failing library.  This made it harder to
track down the root cause than it should have been.

Make a Log.e() call for LibraryLoader failures that prints out the
library that we can't load.

BUG=
==========

[David Trainor- moved to gerrit, 2017-03-02 18:41:35]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2017-03-02 18:42:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 19:32:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488480095325750, "parent_rev":
"29ed2a2bcc95599c41501cbf5a1918735bb96d7b", "commit_rev":
"8c9deb74cf4f697cb0f6bdb589f04085e8d73e63"}

[commit-bot: I haz the power, 2017-03-02 19:36:05]

Description was changed from

==========
Log Android LibraryLoader failures

We recently had a build break that removed a library dependency from Chrome, but
was still required by Android.  Our LibraryLoader attempted to load it and
failed, but didn't actually output the failing library.  This made it harder to
track down the root cause than it should have been.

Make a Log.e() call for LibraryLoader failures that prints out the
library that we can't load.

BUG=
==========

to

==========
Log Android LibraryLoader failures

We recently had a build break that removed a library dependency from Chrome, but
was still required by Android.  Our LibraryLoader attempted to load it and
failed, but didn't actually output the failing library.  This made it harder to
track down the root cause than it should have been.

Make a Log.e() call for LibraryLoader failures that prints out the
library that we can't load.

BUG=

Review-Url: https://codereview.chromium.org/2728513003
Cr-Commit-Position: refs/heads/master@{#454339}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c9deb74cf4f697cb0f6bdb589f0...
==========

[commit-bot: I haz the power, 2017-03-02 19:36:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c9deb74cf4f697cb0f6bdb589f0...