Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2728513002: Revert of Move the FontFaceCache stored in CSSFontSelector to be stored in Document. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by erikchen
Modified:
4 months, 3 weeks ago
Reviewers:
meade_UTC10, drott, sashab, eae
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move the FontFaceCache stored in CSSFontSelector to be stored in Document. (patchset #5 id:80001 of https://codereview.chromium.org/2624893003/ ) Reason for revert: Reverted on suspicion of causing the top renderer crash on Mac. https://bugs.chromium.org/p/chromium/issues/detail?id=696231 Original issue's description: > Move the FontFaceCache stored in CSSFontSelector to be stored in Document. > > This addresses a FIXME found in the code. This FIXME was added in > 2013 by dglazkov in 2013, ad02388f5fcffaab45b9ada7a7dfdcae13ed460f. > > BUG=685945 > > Review-Url: https://codereview.chromium.org/2624893003 > Cr-Commit-Position: refs/heads/master@{#452734} > Committed: https://chromium.googlesource.com/chromium/src/+/e07e958d62db5bb606c0dbbb446d2a25e33c3db1 TBR=drott@chromium.org,eae@chromium.org,sashab@chromium.org,meade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=685945 Review-Url: https://codereview.chromium.org/2728513002 Cr-Commit-Position: refs/heads/master@{#453842} Committed: https://chromium.googlesource.com/chromium/src/+/36809b6d2ff54018e85e75197b52015173aab25d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M third_party/WebKit/Source/core/css/CSSFontSelector.h View 5 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontSelector.cpp View 6 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 7 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 6 (3 generated)
erikchen
Created Revert of Move the FontFaceCache stored in CSSFontSelector to be stored in Document.
4 months, 3 weeks ago (2017-03-01 01:29:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728513002/1
4 months, 3 weeks ago (2017-03-01 01:30:25 UTC) #3
commit-bot: I haz the power
4 months, 3 weeks ago (2017-03-01 04:48:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36809b6d2ff54018e85e75197b52...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973