Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2728493002: Re-format PositionIterator.cpp to be PRESUBMIT friendly (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-format PositionIterator.cpp to be PRESUBMIT friendly This patch re-formats "PositionIterator.cpp" to make it PRESUBMIT friendly and using early-return style for improving code health. This patch is a preparation of [1]. When I'm working on [1], PRESUBMIT detects if-return-else pattern. [1] http://crrev.com/2720593005: Make PositionIterator to handle INPUT, SELECT TEXTAREA in flat tree correctly. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2728493002 Cr-Commit-Position: refs/heads/master@{#453819} Committed: https://chromium.googlesource.com/chromium/src/+/c05f2493ffa65543fae98cfd4ae10dcd11421660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M third_party/WebKit/Source/core/editing/PositionIterator.cpp View 1 chunk +25 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-01 01:21:57 UTC) #5
tkent
lgtm
3 years, 9 months ago (2017-03-01 02:08:59 UTC) #6
Xiaocheng
lgtm
3 years, 9 months ago (2017-03-01 02:32:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728493002/1
3 years, 9 months ago (2017-03-01 03:13:06 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:21:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c05f2493ffa65543fae98cfd4ae1...

Powered by Google App Engine
This is Rietveld 408576698