Remove enterprise serial number recovery feature

Remove enterprise serial number recovery feature

Serial number recovery was introduced to recover the serial number of
devices which did not provide the correct serial number on the initial
enrollment request. This is not a problem anymore so the code can be
removed.

BUG=295504
TEST=Ran all unit_tests

Review-Url: https://codereview.chromium.org/2728463004
Cr-Commit-Position: refs/heads/master@{#472929}
Committed: https://chromium.googlesource.com/chromium/src/+/9911181ef43dfeaaabbd539f39fce567fc5d4e7b

[pmarko, 2017-03-02 17:40:08]

pmarko@chromium.org changed reviewers:
+ tnagel@chromium.org

[pmarko, 2017-03-02 17:40:09]

Hi Thiemo,

please take a look at the changes when you have a few spare minutes!

Thanks,
Pavol

[Thiemo Nagel, 2017-05-02 10:53:07]

Sorry for the *very* slow review.  (Btw, feel free to ping the reviewer when
you've been waiting for them for more than a reasonable amount of time...)

https://codereview.chromium.org/2728463004/diff/20001/components/policy/proto...
File components/policy/proto/device_management_backend.proto (right):

https://codereview.chromium.org/2728463004/diff/20001/components/policy/proto...
components/policy/proto/device_management_backend.proto:226: optional string
machine_id = 5;
I guess this one should be removed too?

https://codereview.chromium.org/2728463004/diff/20001/components/policy/proto...
components/policy/proto/device_management_backend.proto:343: // OBSELETE: Serial
number recovery is no longer supported.
We have changed our approach and now completely remove obsolete fields (but mark
their ids as reserved to avoid re-use.)

[pmarko, 2017-05-17 16:00:21]

No worries, this is not exactly an urgent change :-) PTAL.

https://codereview.chromium.org/2728463004/diff/20001/components/policy/proto...
File components/policy/proto/device_management_backend.proto (right):

https://codereview.chromium.org/2728463004/diff/20001/components/policy/proto...
components/policy/proto/device_management_backend.proto:226: optional string
machine_id = 5;
On 2017/05/02 10:53:06, Thiemo Nagel wrote:
> I guess this one should be removed too?

Yes, I missed it :) thanks. Done.

https://codereview.chromium.org/2728463004/diff/20001/components/policy/proto...
components/policy/proto/device_management_backend.proto:343: // OBSELETE: Serial
number recovery is no longer supported.
On 2017/05/02 10:53:06, Thiemo Nagel wrote:
> We have changed our approach and now completely remove obsolete fields (but
mark
> their ids as reserved to avoid re-use.)

Done.

[Thiemo Nagel, 2017-05-18 14:03:03]

LGTM!  Thank you very much!

[pmarko, 2017-05-18 14:54:42]

The CQ bit was checked by pmarko@chromium.org

[commit-bot: I haz the power, 2017-05-18 14:55:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 15:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 15:43:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pmarko, 2017-05-18 16:38:41]

Thiemo, please take yet another look at the newest patchset - looks like I
forgot to remove the access to the machine_id from policy_testserver.py! :)

[Thiemo Nagel, 2017-05-18 16:54:39]

Still lgtm.

[pmarko, 2017-05-18 16:57:03]

The CQ bit was checked by pmarko@chromium.org

[commit-bot: I haz the power, 2017-05-18 16:57:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 21:00:18]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495126623598690,
"parent_rev": "211f293c93b9a8747ebbffef4701d387ea718cd1", "commit_rev":
"9911181ef43dfeaaabbd539f39fce567fc5d4e7b"}

[commit-bot: I haz the power, 2017-05-18 21:00:28]

Description was changed from

==========
Remove enterprise serial number recovery feature

Serial number recovery was introduced to recover the serial number of
devices which did not provide the correct serial number on the initial
enrollment request. This is not a problem anymore so the code can be
removed.

BUG=295504
TEST=Ran all unit_tests
==========

to

==========
Remove enterprise serial number recovery feature

Serial number recovery was introduced to recover the serial number of
devices which did not provide the correct serial number on the initial
enrollment request. This is not a problem anymore so the code can be
removed.

BUG=295504
TEST=Ran all unit_tests

Review-Url: https://codereview.chromium.org/2728463004
Cr-Commit-Position: refs/heads/master@{#472929}
Committed:
https://chromium.googlesource.com/chromium/src/+/9911181ef43dfeaaabbd539f39fc...
==========

[commit-bot: I haz the power, 2017-05-18 21:00:29]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9911181ef43dfeaaabbd539f39fc...

[Thiemo Nagel, 2017-05-24 09:17:43]

https://codereview.chromium.org/2728463004/diff/80001/components/policy/proto...
File components/policy/proto/device_management_backend.proto (right):

https://codereview.chromium.org/2728463004/diff/80001/components/policy/proto...
components/policy/proto/device_management_backend.proto:190: reserved 5, 10;
Hey Pavol, I've just realized that the "10" actually needs to go into
PolicyData.  Could you please fix?

[pmarko, 2017-05-24 09:41:06]

On 2017/05/24 09:17:43, Thiemo Nagel wrote:
>
https://codereview.chromium.org/2728463004/diff/80001/components/policy/proto...
> File components/policy/proto/device_management_backend.proto (right):
> 
>
https://codereview.chromium.org/2728463004/diff/80001/components/policy/proto...
> components/policy/proto/device_management_backend.proto:190: reserved 5, 10;
> Hey Pavol, I've just realized that the "10" actually needs to go into
> PolicyData.  Could you please fix?

Whoops :)
https://chromium-review.googlesource.com/c/514082/

[pmarko, 2017-05-24 09:42:11]

https://codereview.chromium.org/2728463004/diff/80001/components/policy/proto...
File components/policy/proto/device_management_backend.proto (right):

https://codereview.chromium.org/2728463004/diff/80001/components/policy/proto...
components/policy/proto/device_management_backend.proto:190: reserved 5, 10;
On 2017/05/24 09:17:42, Thiemo Nagel wrote:
> Hey Pavol, I've just realized that the "10" actually needs to go into
> PolicyData.  Could you please fix?

Good catch. Fix CL up:
https://chromium-review.googlesource.com/c/514082/