Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2728433002: Unnecessarily cursor appears in omnibox after clicking inside the 'Search box' (Closed)

Created:
3 years, 9 months ago by yiyix
Modified:
3 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the unnecessarily cursor appeared in omnibox after clicking inside the 'Search box' BUG=696894 Review-Url: https://codereview.chromium.org/2728433002 Cr-Commit-Position: refs/heads/master@{#454148} Committed: https://chromium.googlesource.com/chromium/src/+/413ab9af7d2755e3287b07b08c21fc3be062103c

Patch Set 1 #

Patch Set 2 : add tests #

Patch Set 3 : nits #

Total comments: 4

Patch Set 4 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M ui/views/controls/textfield/textfield.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield_test_api.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
yiyix
@sadrul, could you please take a look at this change? Thank you very much
3 years, 9 months ago (2017-02-28 21:59:50 UTC) #5
sadrul
looks good! Is it possible to write a test for this?
3 years, 9 months ago (2017-03-01 15:33:28 UTC) #6
yiyix
On 2017/03/01 15:33:28, sadrul wrote: > looks good! Is it possible to write a test ...
3 years, 9 months ago (2017-03-01 20:34:30 UTC) #7
sadrul
I think what you have is good. Maybe it could be a little bit cleaner? ...
3 years, 9 months ago (2017-03-01 20:51:24 UTC) #8
yiyix
@sadrul, could you please check this version again? Thank you very much. https://codereview.chromium.org/2728433002/diff/40001/ui/views/controls/textfield/textfield.cc File ui/views/controls/textfield/textfield.cc ...
3 years, 9 months ago (2017-03-01 22:18:58 UTC) #11
sadrul
Thanks! lgtm
3 years, 9 months ago (2017-03-01 23:59:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728433002/60001
3 years, 9 months ago (2017-03-02 01:51:52 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 02:01:08 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/413ab9af7d2755e3287b07b08c21...

Powered by Google App Engine
This is Rietveld 408576698