Issue 2728393003: Intercept WebVR api calls and check for VrCore compatibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2728393003: Intercept WebVR api calls and check for VrCore compatibility. (Closed)

Created:
3 years, 9 months ago by bshe

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Intercept WebVR api calls and check for VrCore compatibility. Proof of concept only, not ready for submitting. BUG=670166 Review-Url: https://codereview.chromium.org/2701523008 Cr-Commit-Position: refs/heads/master@{#454482} (cherry picked from commit 24b50378a13f0099e231bcbfefaea67eec005ab3) Review-Url: https://codereview.chromium.org/2728393003 . Cr-Commit-Position: refs/branch-heads/3029@{#33} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/19417faca2532a7db0082040e47fbea53cea5c48

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -32 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java	View	7 chunks	+14 lines, -29 lines	0 comments	Download

Total messages: 2 (1 generated)

bshe

3 years, 9 months ago (2017-03-06 23:50:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
19417faca2532a7db0082040e47fbea53cea5c48.