Make ::first-line invalidation work when added or removed.

Make ::first-line invalidation work when added or removed.

We were only invalidating ::first-line properly when both old and new
ComputedStyle contained ::first-line styles. Now, instead call
setNeedsLayoutAndPrefWidthsRecalc to trigger changes when either old or
new ComputedStyle does not have ::first-line style.

The ::first-line invalidation is moved from Element to LayoutObject,
and unnecessary traversal code removed.

I have not been able to come up with a case where we need to compare
PseudoIdFirstLineInherited style, so diffing that is removed.

R=mstensho@opera.com
BUG=562418, 564239, 689979
Review-Url: https://codereview.chromium.org/2728383002
Cr-Commit-Position: refs/heads/master@{#455088}
Committed: https://chromium.googlesource.com/chromium/src/+/3f2d0c6bbce99fc2880356ff2ebfd323b5bcd8bc

[rune, 2017-03-06 15:17:07]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 15:17:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-03-06 15:17:30]

ptal

[commit-bot: I haz the power, 2017-03-06 17:43:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 17:43:18]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2017-03-07 10:04:27]

lgtm

https://codereview.chromium.org/2728383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2728383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1954: if
(styleRef().hasPseudoStyle(PseudoIdFirstLine) && oldPseudoStyle)
This will never be true if oldStyle.hasPseudoStyle(PseudoIdFirstLine) was false,
so I suggest moving it into the above block.

https://codereview.chromium.org/2728383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1956: if (oldPseudoStyle
&& newPseudoStyle)
Ditto - if you just return after the firstLineStyleDidChange() call.

[rune, 2017-03-07 10:42:54]

https://codereview.chromium.org/2728383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2728383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1954: if
(styleRef().hasPseudoStyle(PseudoIdFirstLine) && oldPseudoStyle)
On 2017/03/07 10:04:26, mstensho wrote:
> This will never be true if oldStyle.hasPseudoStyle(PseudoIdFirstLine) was
false,
> so I suggest moving it into the above block.

Done.

https://codereview.chromium.org/2728383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1956: if (oldPseudoStyle
&& newPseudoStyle)
On 2017/03/07 10:04:26, mstensho wrote:
> Ditto - if you just return after the firstLineStyleDidChange() call.

Done.

[rune, 2017-03-07 10:42:59]

The CQ bit was checked by rune@opera.com

[rune, 2017-03-07 10:42:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mstensho@opera.com
Link to the patchset: https://codereview.chromium.org/2728383002/#ps20001
(title: "Fixed review issues.")

[commit-bot: I haz the power, 2017-03-07 10:43:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 11:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 11:43:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rune, 2017-03-07 12:19:12]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-03-07 12:19:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 16:09:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488889152006800,
"parent_rev": "31211cb8a35a8d9f6664a0f1f6d1957576e077e3", "commit_rev":
"3f2d0c6bbce99fc2880356ff2ebfd323b5bcd8bc"}

[commit-bot: I haz the power, 2017-03-07 16:10:02]

Description was changed from

==========
Make ::first-line invalidation work when added or removed.

We were only invalidating ::first-line properly when both old and new
ComputedStyle contained ::first-line styles. Now, instead call
setNeedsLayoutAndPrefWidthsRecalc to trigger changes when either old or
new ComputedStyle does not have ::first-line style.

The ::first-line invalidation is moved from Element to LayoutObject,
and unnecessary traversal code removed.

I have not been able to come up with a case where we need to compare
PseudoIdFirstLineInherited style, so diffing that is removed.

R=mstensho@opera.com
BUG=562418,564239,689979
==========

to

==========
Make ::first-line invalidation work when added or removed.

We were only invalidating ::first-line properly when both old and new
ComputedStyle contained ::first-line styles. Now, instead call
setNeedsLayoutAndPrefWidthsRecalc to trigger changes when either old or
new ComputedStyle does not have ::first-line style.

The ::first-line invalidation is moved from Element to LayoutObject,
and unnecessary traversal code removed.

I have not been able to come up with a case where we need to compare
PseudoIdFirstLineInherited style, so diffing that is removed.

R=mstensho@opera.com
BUG=562418,564239,689979

Review-Url: https://codereview.chromium.org/2728383002
Cr-Commit-Position: refs/heads/master@{#455088}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f2d0c6bbce99fc2880356ff2ebf...
==========

[commit-bot: I haz the power, 2017-03-07 16:10:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3f2d0c6bbce99fc2880356ff2ebf...