Fixs bug resulting in double event delivery in mus

Fixs bug resulting in double event delivery in mus

EventGenerator::DoDispatchEvent() sends to IME and if not handled
processes the event. For mus this results in double the events as IME
routes to the right source, and then because the event wasn't handled
EventGenerator::DoDispatchEvent() processes as well. This was
resulting in some tests incorrectly failing that use EventGenerator.

BUG=693114
TEST=none
R=moshayedi@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2728373003
Cr-Commit-Position: refs/heads/master@{#455184}
Committed: https://chromium.googlesource.com/chromium/src/+/d43cd7f2d1b33ba4954de9a6d7c362962a0347ec

[sky, 2017-03-06 22:08:19]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 22:08:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 23:20:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 23:21:00]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-03-07 03:07:19]

lgtm

https://codereview.chromium.org/2728373003/diff/20001/ui/views/test/views_tes...
File ui/views/test/views_test_base.h (right):

https://codereview.chromium.org/2728373003/diff/20001/ui/views/test/views_tes...
ui/views/test/views_test_base.h:53: // ime to ack the event.
Are there any tests that actually does wait for the ack from ime? Or should we
just make this the default?

[sky, 2017-03-07 04:56:57]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 04:57:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-07 04:58:29]

Take another look?

https://codereview.chromium.org/2728373003/diff/20001/ui/views/test/views_tes...
File ui/views/test/views_test_base.h (right):

https://codereview.chromium.org/2728373003/diff/20001/ui/views/test/views_tes...
ui/views/test/views_test_base.h:53: // ime to ack the event.
On 2017/03/07 03:07:19, sadrul wrote:
> Are there any tests that actually does wait for the ack from ime? Or should we
> just make this the default?

I thought some tests might want to talk to the server, but then given we run
these tests concurrently that is likely problematic. So, changed. The casts are
a bit ick.

[commit-bot: I haz the power, 2017-03-07 06:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 06:35:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Hadi, 2017-03-07 14:50:26]

lgtm

[sky, 2017-03-07 18:10:31]

On 2017/03/07 04:58:29, sky wrote:
> Take another look?
> 
>
https://codereview.chromium.org/2728373003/diff/20001/ui/views/test/views_tes...
> File ui/views/test/views_test_base.h (right):
> 
>
https://codereview.chromium.org/2728373003/diff/20001/ui/views/test/views_tes...
> ui/views/test/views_test_base.h:53: // ime to ack the event.
> On 2017/03/07 03:07:19, sadrul wrote:
> > Are there any tests that actually does wait for the ack from ime? Or should
we
> > just make this the default?
> 
> I thought some tests might want to talk to the server, but then given we run
> these tests concurrently that is likely problematic. So, changed. The casts
are
> a bit ick.

I'm going to land this, if you have any concerns Sadrul I'll address them.

[sky, 2017-03-07 18:10:36]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-07 18:10:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2728373003/#ps40001
(title: "global disable")

[commit-bot: I haz the power, 2017-03-07 18:12:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 20:00:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488910236968560,
"parent_rev": "ccfb6cf6ad9a2a620bce844f795b902fcfb81f43", "commit_rev":
"d43cd7f2d1b33ba4954de9a6d7c362962a0347ec"}

[commit-bot: I haz the power, 2017-03-07 20:00:42]

Description was changed from

==========
Fixs bug resulting in double event delivery in mus

EventGenerator::DoDispatchEvent() sends to IME and if not handled
processes the event. For mus this results in double the events as IME
routes to the right source, and then because the event wasn't handled
EventGenerator::DoDispatchEvent() processes as well. This was
resulting in some tests incorrectly failing that use EventGenerator.

BUG=693114
TEST=none
R=moshayedi@chromium.org, sadrul@chromium.org
==========

to

==========
Fixs bug resulting in double event delivery in mus

EventGenerator::DoDispatchEvent() sends to IME and if not handled
processes the event. For mus this results in double the events as IME
routes to the right source, and then because the event wasn't handled
EventGenerator::DoDispatchEvent() processes as well. This was
resulting in some tests incorrectly failing that use EventGenerator.

BUG=693114
TEST=none
R=moshayedi@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2728373003
Cr-Commit-Position: refs/heads/master@{#455184}
Committed:
https://chromium.googlesource.com/chromium/src/+/d43cd7f2d1b33ba4954de9a6d7c3...
==========

[commit-bot: I haz the power, 2017-03-07 20:00:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d43cd7f2d1b33ba4954de9a6d7c3...

[sadrul, 2017-03-08 01:59:07]

yep lgtm thanks (sorry, was ooo today)