Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2728363002: [heap] Implement concurrent marking boilerplate. (Closed)

Created:
3 years, 9 months ago by ulan
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Implement concurrent marking boilerplate. This patch adds a trivial ConcurrentMarking class that can start background tasks. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2728363002 Cr-Commit-Position: refs/heads/master@{#43615} Committed: https://chromium.googlesource.com/v8/v8/+/e96b5ed423bd6c566c1b11d54303c29cdfd473c7

Patch Set 1 #

Patch Set 2 : Add missing test file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
A src/heap/concurrent-marking.h View 1 chunk +48 lines, -0 lines 2 comments Download
A src/heap/concurrent-marking.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M src/heap/heap.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/heap/test-concurrent-marking.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ulan
ptal
3 years, 9 months ago (2017-03-06 13:31:00 UTC) #2
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/2728363002/diff/20001/src/heap/concurrent-marking.h File src/heap/concurrent-marking.h (right): https://codereview.chromium.org/2728363002/diff/20001/src/heap/concurrent-marking.h#newcode22 src/heap/concurrent-marking.h:22: static const int kMaxNumberOfTasks = 10; Instead of ...
3 years, 9 months ago (2017-03-06 13:43:19 UTC) #3
Michael Lippautz
lgtm
3 years, 9 months ago (2017-03-06 13:45:27 UTC) #4
ulan
https://codereview.chromium.org/2728363002/diff/20001/src/heap/concurrent-marking.h File src/heap/concurrent-marking.h (right): https://codereview.chromium.org/2728363002/diff/20001/src/heap/concurrent-marking.h#newcode22 src/heap/concurrent-marking.h:22: static const int kMaxNumberOfTasks = 10; On 2017/03/06 13:43:19, ...
3 years, 9 months ago (2017-03-06 13:52:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728363002/20001
3 years, 9 months ago (2017-03-06 14:52:55 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 15:19:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e96b5ed423bd6c566c1b11d54303c29cdfd...

Powered by Google App Engine
This is Rietveld 408576698