Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: components/autofill/content/common/autofill_types_struct_traits_unittest.cc

Issue 2728353002: [Password Generation] Process CONFIRMATION_PASSWORD votes on the client side (Closed)
Patch Set: Removed PasswordFormGenerationData constructor that is used only in tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/common/autofill_types_struct_traits_unittest.cc
diff --git a/components/autofill/content/common/autofill_types_struct_traits_unittest.cc b/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
index f4ab58b127852c07aab822d029274f0db98d751c..547f0a542da2d88de6bcc099c05ae26da573430a 100644
--- a/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
+++ b/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
@@ -201,6 +201,10 @@ void CheckEqualPasswordFormGenerationData(
const PasswordFormGenerationData& actual) {
EXPECT_EQ(expected.form_signature, actual.form_signature);
EXPECT_EQ(expected.field_signature, actual.field_signature);
+ ASSERT_EQ(expected.confirmation_field_signature.has_value(),
+ actual.confirmation_field_signature.has_value());
+ EXPECT_EQ(expected.confirmation_field_signature.value(),
+ actual.confirmation_field_signature.value());
}
} // namespace
@@ -407,7 +411,11 @@ TEST_F(AutofillTypeTraitsTestImpl, PassPasswordFormGenerationData) {
FormSignature form_signature = CalculateFormSignature(form);
FieldSignature field_signature =
CalculateFieldSignatureForField(form.fields[0]);
- PasswordFormGenerationData input{form_signature, field_signature};
+ FieldSignature confirmation_field_signature =
+ CalculateFieldSignatureForField(form.fields[1]);
+ PasswordFormGenerationData input(form_signature, field_signature);
+ input.confirmation_field_signature =
+ base::Optional<FieldSignature>(confirmation_field_signature);
base::RunLoop loop;
mojom::TypeTraitsTestPtr proxy = GetTypeTraitsTestProxy();

Powered by Google App Engine
This is Rietveld 408576698