[Password Generation] Process CONFIRMATION_PASSWORD votes on the client side

components/autofill/content/common/autofill_types_struct_traits.cc

Index: components/autofill/content/common/autofill_types_struct_traits.cc
diff --git a/components/autofill/content/common/autofill_types_struct_traits.cc b/components/autofill/content/common/autofill_types_struct_traits.cc
index 1b3d8ab62146fb33376c50dda3577bb92d802008..1caeec9d5200c3f1b49c0a3dfc32381115c62c4b 100644
--- a/components/autofill/content/common/autofill_types_struct_traits.cc
+++ b/components/autofill/content/common/autofill_types_struct_traits.cc
@@ -474,6 +474,10 @@ bool StructTraits<mojom::PasswordFormGenerationDataDataView,
          PasswordFormGenerationData* out) {
   out->form_signature = data.form_signature();
   out->field_signature = data.field_signature();
+  out->confirmation_field_signature =

[dcheng, 2017/03/07 21:42:26]

I would just write this as:

if (data.has_confirmation_field()) {
  out->confirmation_field_signature.emplace(
      data.confirmation_field_signature());
}

(You can DCHECK that it's unset in the else case if you want)

[kolos1, 2017/03/08 07:43:50]

Done.

+      data.has_confirmation_field()
+          ? base::Optional<FieldSignature>(data.confirmation_field_signature())
+          : base::Optional<FieldSignature>();
   return true;
 }