Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2728343002: Refactor CopyTexture method determination (Closed)

Created:
3 years, 9 months ago by qiankun
Modified:
3 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor CopyTexture method determination Separate validations from method calculation. Move method calculation to a common function. BUG=612542 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2728343002 Cr-Commit-Position: refs/heads/master@{#455015} Committed: https://chromium.googlesource.com/chromium/src/+/77fb94be2f982ec3d944c4fff739076f517c6c94

Patch Set 1 #

Patch Set 2 : fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -61 lines) Patch
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 2 chunks +2 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 8 chunks +62 lines, -41 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
qiankun
PTAL
3 years, 9 months ago (2017-03-06 13:55:58 UTC) #11
Zhenyao Mo
On 2017/03/06 13:55:58, qiankun wrote: > PTAL lgtm
3 years, 9 months ago (2017-03-06 22:49:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728343002/20001
3 years, 9 months ago (2017-03-07 01:14:00 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 01:21:06 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/77fb94be2f982ec3d944c4fff739...

Powered by Google App Engine
This is Rietveld 408576698