Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1037)

Issue 2728253003: Revert of ShapeDetection: add support for Text Detection in Mac (Closed)

Created:
3 years, 2 months ago by Avi (use Gerrit)
Modified:
3 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mac-reviews_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, vmpstr+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ShapeDetection: add support for Text Detection in Mac (patchset #4 id:80001 of https://codereview.chromium.org/2726843006/ ) Reason for revert: ../../services/shape_detection/text_detection_impl_mac.mm:68:8: > error: 'CIRectangleFeature' is only available on macOS 10_10 or newer Original issue's description: > ShapeDetection: add support for Text Detection in Mac > > This CL adds text detection for Mac in services/shape_detection, > and also adds unittest for it, that will be run, like the > other specific unittests, in the mac gpu bots. > > BUG=697925 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel > TEST= unittests that can be run anywhere like this: > out/gn/service_unittests --gtest_filter=*TextDetection* --use-gpu-in-tests > > and demo page, e.g. > ./out/gn/Chromium.app/Contents/MacOS/Chromium --enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg > > Review-Url: https://codereview.chromium.org/2726843006 > Cr-Commit-Position: refs/heads/master@{#454609} > Committed: https://chromium.googlesource.com/chromium/src/+/de6e85f0f4d505692f11c7f2d1c39f043f702796 TBR=rockot@chromium.org,reillyg@chromium.org,tsepez@chromium.org,mcasas@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=697925 Review-Url: https://codereview.chromium.org/2728253003 Cr-Commit-Position: refs/heads/master@{#454785} Committed: https://chromium.googlesource.com/chromium/src/+/0832734083fedd1000e5e871071a78ff93b57a29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -297 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +0 lines, -12 lines 0 comments Download
M base/mac/sdk_forward_declarations.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M services/shape_detection/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
M services/shape_detection/manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M services/shape_detection/shape_detection_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D services/shape_detection/text_detection_impl.h View 1 chunk +0 lines, -24 lines 0 comments Download
D services/shape_detection/text_detection_impl.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D services/shape_detection/text_detection_impl_mac.h View 1 chunk +0 lines, -33 lines 0 comments Download
D services/shape_detection/text_detection_impl_mac.mm View 1 chunk +0 lines, -83 lines 0 comments Download
D services/shape_detection/text_detection_impl_mac_unittest.mm View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Avi (use Gerrit)
Created Revert of ShapeDetection: add support for Text Detection in Mac
3 years, 2 months ago (2017-03-04 23:32:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728253003/1
3 years, 2 months ago (2017-03-04 23:32:57 UTC) #3
commit-bot: I haz the power
3 years, 2 months ago (2017-03-05 00:30:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0832734083fedd1000e5e871071a...

Powered by Google App Engine
This is Rietveld 408576698