third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h - Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)

Patch Set: Really fix reivewer comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/VisualViewport.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

index 24f17a566b162376a473503f3114f0801b4bd991..787279c1e517ddb10de66395b383c25ff1a84e13 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

@@ -49,6 +49,7 @@ class Page;

class PaintLayer;

class Region;

class ScrollableArea;

+class WebLayer;

class WebLayerTreeView;

class WebScrollbarLayer;

@@ -105,7 +106,8 @@ class CORE_EXPORT ScrollingCoordinator final

ScrollbarOrientation,

int thumbThickness,

int trackStart,

- bool isLeftSideVerticalScrollbar);

+ bool isLeftSideVerticalScrollbar,

+ WebLayer* scrollLayer);

void willDestroyScrollableArea(ScrollableArea*);

// Returns true if the coordinator handled this change.