Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)
Patch Set: Really fix reivewer comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 class CompositorAnimationHost; 42 class CompositorAnimationHost;
43 class CompositorAnimationTimeline; 43 class CompositorAnimationTimeline;
44 class LayoutBox; 44 class LayoutBox;
45 class LocalFrame; 45 class LocalFrame;
46 class FrameView; 46 class FrameView;
47 class GraphicsLayer; 47 class GraphicsLayer;
48 class Page; 48 class Page;
49 class PaintLayer; 49 class PaintLayer;
50 class Region; 50 class Region;
51 class ScrollableArea; 51 class ScrollableArea;
52 class WebLayer;
52 class WebLayerTreeView; 53 class WebLayerTreeView;
53 class WebScrollbarLayer; 54 class WebScrollbarLayer;
54 55
55 class CORE_EXPORT ScrollingCoordinator final 56 class CORE_EXPORT ScrollingCoordinator final
56 : public GarbageCollectedFinalized<ScrollingCoordinator> { 57 : public GarbageCollectedFinalized<ScrollingCoordinator> {
57 WTF_MAKE_NONCOPYABLE(ScrollingCoordinator); 58 WTF_MAKE_NONCOPYABLE(ScrollingCoordinator);
58 59
59 public: 60 public:
60 static ScrollingCoordinator* create(Page*); 61 static ScrollingCoordinator* create(Page*);
61 62
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // Should be called whenever the set of fixed objects changes. 99 // Should be called whenever the set of fixed objects changes.
99 void frameViewFixedObjectsDidChange(FrameView*); 100 void frameViewFixedObjectsDidChange(FrameView*);
100 101
101 // Should be called whenever the root layer for the given frame view changes. 102 // Should be called whenever the root layer for the given frame view changes.
102 void frameViewRootLayerDidChange(FrameView*); 103 void frameViewRootLayerDidChange(FrameView*);
103 104
104 std::unique_ptr<WebScrollbarLayer> createSolidColorScrollbarLayer( 105 std::unique_ptr<WebScrollbarLayer> createSolidColorScrollbarLayer(
105 ScrollbarOrientation, 106 ScrollbarOrientation,
106 int thumbThickness, 107 int thumbThickness,
107 int trackStart, 108 int trackStart,
108 bool isLeftSideVerticalScrollbar); 109 bool isLeftSideVerticalScrollbar,
110 WebLayer* scrollLayer);
109 111
110 void willDestroyScrollableArea(ScrollableArea*); 112 void willDestroyScrollableArea(ScrollableArea*);
111 // Returns true if the coordinator handled this change. 113 // Returns true if the coordinator handled this change.
112 bool scrollableAreaScrollLayerDidChange(ScrollableArea*); 114 bool scrollableAreaScrollLayerDidChange(ScrollableArea*);
113 void scrollableAreaScrollbarLayerDidChange(ScrollableArea*, 115 void scrollableAreaScrollbarLayerDidChange(ScrollableArea*,
114 ScrollbarOrientation); 116 ScrollbarOrientation);
115 void setLayerIsContainerForFixedPositionLayers(GraphicsLayer*, bool); 117 void setLayerIsContainerForFixedPositionLayers(GraphicsLayer*, bool);
116 void updateLayerPositionConstraint(PaintLayer*); 118 void updateLayerPositionConstraint(PaintLayer*);
117 void touchEventTargetRectsDidChange(); 119 void touchEventTargetRectsDidChange();
118 void willDestroyLayer(PaintLayer*); 120 void willDestroyLayer(PaintLayer*);
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 ScrollbarMap m_verticalScrollbars; 185 ScrollbarMap m_verticalScrollbars;
184 HashSet<const PaintLayer*> m_layersWithTouchRects; 186 HashSet<const PaintLayer*> m_layersWithTouchRects;
185 bool m_wasFrameScrollable; 187 bool m_wasFrameScrollable;
186 188
187 MainThreadScrollingReasons m_lastMainThreadScrollingReasons; 189 MainThreadScrollingReasons m_lastMainThreadScrollingReasons;
188 }; 190 };
189 191
190 } // namespace blink 192 } // namespace blink
191 193
192 #endif // ScrollingCoordinator_h 194 #endif // ScrollingCoordinator_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698