Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3281)

Unified Diff: cc/blink/web_scrollbar_layer_impl.h

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)
Patch Set: Really fix reivewer comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/blink/web_compositor_support_impl.cc ('k') | cc/blink/web_scrollbar_layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/blink/web_scrollbar_layer_impl.h
diff --git a/cc/blink/web_scrollbar_layer_impl.h b/cc/blink/web_scrollbar_layer_impl.h
index ad203e9a9563e115e5779e865f57aa07fb3bc700..657c90a70e081bdcd3ceaa18bf48f9b3e3c28dea 100644
--- a/cc/blink/web_scrollbar_layer_impl.h
+++ b/cc/blink/web_scrollbar_layer_impl.h
@@ -26,22 +26,19 @@ class WebScrollbarLayerImpl : public blink::WebScrollbarLayer {
CC_BLINK_EXPORT WebScrollbarLayerImpl(
std::unique_ptr<blink::WebScrollbar> scrollbar,
blink::WebScrollbarThemePainter painter,
- std::unique_ptr<blink::WebScrollbarThemeGeometry> geometry);
- CC_BLINK_EXPORT WebScrollbarLayerImpl(
- std::unique_ptr<blink::WebScrollbar> scrollbar,
- blink::WebScrollbarThemePainter painter,
std::unique_ptr<blink::WebScrollbarThemeGeometry> geometry,
- bool temp);
+ bool is_overlay,
+ blink::WebLayer* scroll_layer);
CC_BLINK_EXPORT WebScrollbarLayerImpl(
blink::WebScrollbar::Orientation orientation,
int thumb_thickness,
int track_start,
- bool is_left_side_vertical_scrollbar);
+ bool is_left_side_vertical_scrollbar,
+ blink::WebLayer* scroll_layer);
~WebScrollbarLayerImpl() override;
// blink::WebScrollbarLayer implementation.
blink::WebLayer* layer() override;
- void setScrollLayer(blink::WebLayer* layer) override;
private:
std::unique_ptr<WebLayerImpl> layer_;
« no previous file with comments | « cc/blink/web_compositor_support_impl.cc ('k') | cc/blink/web_scrollbar_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698