Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: cc/blink/web_scrollbar_layer_impl.h

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)
Patch Set: Really fix reivewer comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/blink/web_compositor_support_impl.cc ('k') | cc/blink/web_scrollbar_layer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_BLINK_WEB_SCROLLBAR_LAYER_IMPL_H_ 5 #ifndef CC_BLINK_WEB_SCROLLBAR_LAYER_IMPL_H_
6 #define CC_BLINK_WEB_SCROLLBAR_LAYER_IMPL_H_ 6 #define CC_BLINK_WEB_SCROLLBAR_LAYER_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "cc/blink/cc_blink_export.h" 11 #include "cc/blink/cc_blink_export.h"
12 #include "third_party/WebKit/public/platform/WebScrollbar.h" 12 #include "third_party/WebKit/public/platform/WebScrollbar.h"
13 #include "third_party/WebKit/public/platform/WebScrollbarLayer.h" 13 #include "third_party/WebKit/public/platform/WebScrollbarLayer.h"
14 14
15 namespace blink { 15 namespace blink {
16 class WebScrollbarThemeGeometry; 16 class WebScrollbarThemeGeometry;
17 class WebScrollbarThemePainter; 17 class WebScrollbarThemePainter;
18 } 18 }
19 19
20 namespace cc_blink { 20 namespace cc_blink {
21 21
22 class WebLayerImpl; 22 class WebLayerImpl;
23 23
24 class WebScrollbarLayerImpl : public blink::WebScrollbarLayer { 24 class WebScrollbarLayerImpl : public blink::WebScrollbarLayer {
25 public: 25 public:
26 CC_BLINK_EXPORT WebScrollbarLayerImpl( 26 CC_BLINK_EXPORT WebScrollbarLayerImpl(
27 std::unique_ptr<blink::WebScrollbar> scrollbar, 27 std::unique_ptr<blink::WebScrollbar> scrollbar,
28 blink::WebScrollbarThemePainter painter, 28 blink::WebScrollbarThemePainter painter,
29 std::unique_ptr<blink::WebScrollbarThemeGeometry> geometry);
30 CC_BLINK_EXPORT WebScrollbarLayerImpl(
31 std::unique_ptr<blink::WebScrollbar> scrollbar,
32 blink::WebScrollbarThemePainter painter,
33 std::unique_ptr<blink::WebScrollbarThemeGeometry> geometry, 29 std::unique_ptr<blink::WebScrollbarThemeGeometry> geometry,
34 bool temp); 30 bool is_overlay,
31 blink::WebLayer* scroll_layer);
35 CC_BLINK_EXPORT WebScrollbarLayerImpl( 32 CC_BLINK_EXPORT WebScrollbarLayerImpl(
36 blink::WebScrollbar::Orientation orientation, 33 blink::WebScrollbar::Orientation orientation,
37 int thumb_thickness, 34 int thumb_thickness,
38 int track_start, 35 int track_start,
39 bool is_left_side_vertical_scrollbar); 36 bool is_left_side_vertical_scrollbar,
37 blink::WebLayer* scroll_layer);
40 ~WebScrollbarLayerImpl() override; 38 ~WebScrollbarLayerImpl() override;
41 39
42 // blink::WebScrollbarLayer implementation. 40 // blink::WebScrollbarLayer implementation.
43 blink::WebLayer* layer() override; 41 blink::WebLayer* layer() override;
44 void setScrollLayer(blink::WebLayer* layer) override;
45 42
46 private: 43 private:
47 std::unique_ptr<WebLayerImpl> layer_; 44 std::unique_ptr<WebLayerImpl> layer_;
48 45
49 DISALLOW_COPY_AND_ASSIGN(WebScrollbarLayerImpl); 46 DISALLOW_COPY_AND_ASSIGN(WebScrollbarLayerImpl);
50 }; 47 };
51 48
52 } // namespace cc_blink 49 } // namespace cc_blink
53 50
54 #endif // CC_BLINK_WEB_SCROLLBAR_LAYER_IMPL_H_ 51 #endif // CC_BLINK_WEB_SCROLLBAR_LAYER_IMPL_H_
OLDNEW
« no previous file with comments | « cc/blink/web_compositor_support_impl.cc ('k') | cc/blink/web_scrollbar_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698