Use targetFrame to decide whether to allow load in static html view.

Use targetFrame to decide whether to allow load in static html view.

StaticHtmlViewController intercepts attempted main frame navigations
and performs the load using the UrlLoader protocol.  Currently,
navigations are ignored unless their reported sourceFrame is the main
frame.  However, this has the mistaken behavior of intercepting loads
that are initiated by the main frame, but are intended for a subframe.
Additionally, the current implementation will not intercept navigations
triggered by JavaScript (e.g. setting window.location to a new URL), as
these are reported as having a nil sourceFrame, but the main frame as the
targetFrame.  Since the same-origin policy is enforced by WebKit before
WKWebView navigation callbacks can occur, we can assume that an
navigation with the main frame as the targetFrame are valid and should be
intercepted.

BUG=695262
Review-Url: https://codereview.chromium.org/2728243002
Cr-Commit-Position: refs/heads/master@{#454723}
Committed: https://chromium.googlesource.com/chromium/src/+/0f799230c0f27e3e8882868f46d9d5cefe9c8c6d

[kkhorimoto, 2017-03-03 23:51:13]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[kkhorimoto, 2017-03-03 23:51:14]

PTAL at this M57 RBS fix

[Eugene But (OOO till 7-30), 2017-03-04 00:02:21]

lgtm

[kkhorimoto, 2017-03-04 00:02:43]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-03-04 00:03:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 00:03:07]

This CL has an open dependency (Issue 2731553003 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[kkhorimoto, 2017-03-04 00:15:57]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-03-04 00:15:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2728243002/#ps20001
(title: "reparent branch")

[commit-bot: I haz the power, 2017-03-04 00:16:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 00:28:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488586557656560,
"parent_rev": "6041948056b934235c89d959481499d6c264a46a", "commit_rev":
"0f799230c0f27e3e8882868f46d9d5cefe9c8c6d"}

[commit-bot: I haz the power, 2017-03-04 00:29:02]

Description was changed from

==========
Use targetFrame to decide whether to allow load in static html view.

StaticHtmlViewController intercepts attempted main frame navigations
and performs the load using the UrlLoader protocol.  Currently,
navigations are ignored unless their reported sourceFrame is the main
frame.  However, this has the mistaken behavior of intercepting loads
that are initiated by the main frame, but are intended for a subframe.
Additionally, the current implementation will not intercept navigations
triggered by JavaScript (e.g. setting window.location to a new URL), as
these are reported as having a nil sourceFrame, but the main frame as the
targetFrame.  Since the same-origin policy is enforced by WebKit before
WKWebView navigation callbacks can occur, we can assume that an
navigation with the main frame as the targetFrame are valid and should be
intercepted.

BUG=695262
==========

to

==========
Use targetFrame to decide whether to allow load in static html view.

StaticHtmlViewController intercepts attempted main frame navigations
and performs the load using the UrlLoader protocol.  Currently,
navigations are ignored unless their reported sourceFrame is the main
frame.  However, this has the mistaken behavior of intercepting loads
that are initiated by the main frame, but are intended for a subframe.
Additionally, the current implementation will not intercept navigations
triggered by JavaScript (e.g. setting window.location to a new URL), as
these are reported as having a nil sourceFrame, but the main frame as the
targetFrame.  Since the same-origin policy is enforced by WebKit before
WKWebView navigation callbacks can occur, we can assume that an
navigation with the main frame as the targetFrame are valid and should be
intercepted.

BUG=695262

Review-Url: https://codereview.chromium.org/2728243002
Cr-Commit-Position: refs/heads/master@{#454723}
Committed:
https://chromium.googlesource.com/chromium/src/+/0f799230c0f27e3e8882868f46d9...
==========

[commit-bot: I haz the power, 2017-03-04 00:29:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f799230c0f27e3e8882868f46d9...