third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp - Issue 2728193003: Show download button even when preload=none

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

Issue 2728193003: Show download button even when preload=none (Closed)

Patch Set: Fix incorrect download button unit test and rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

index 19caa77d06e23f5d97f51275f8c21f9d241465f0..12daa4291017cc145ca83bb58e8545b86682aaf6 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

@@ -400,7 +400,7 @@ TEST_F(MediaControlsTest, DownloadButtonDisplayedHiddenAndDisplayed) {

// Hide button.

mediaControls().mediaElement().setSrc("");

testing::runPendingTasks();

- EXPECT_TRUE(isElementVisible(*downloadButton));

+ EXPECT_FALSE(isElementVisible(*downloadButton));

histogramTester().expectBucketCount("Media.Controls.Download",

DownloadActionMetrics::Shown, 1);

whywhat 2017/03/07 12:50:56 Strange you don't need to update that. Shouldn't t

steimel 2017/03/07 15:26:21 Hmm I'm not actually sure what that's measuring ex