Show download button even when preload=none

third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/html/shadow/MediaControls.h"
 
 #include <limits>
 #include <memory>
 #include "core/HTMLNames.h"
 #include "core/css/StylePropertySet.h"
@@ skipping 382 matching lines @@
   mediaControls().mediaElement().setSrc("https://example.com/foo.mp4");
   testing::runPendingTasks();
   simulateLoadedMetadata();
   EXPECT_TRUE(isElementVisible(*downloadButton));
   histogramTester().expectBucketCount("Media.Controls.Download",
                                       DownloadActionMetrics::Shown, 1);
 
   // Hide button.
   mediaControls().mediaElement().setSrc("");
   testing::runPendingTasks();
-  EXPECT_TRUE(isElementVisible(*downloadButton));
+  EXPECT_FALSE(isElementVisible(*downloadButton));
   histogramTester().expectBucketCount("Media.Controls.Download",
                                       DownloadActionMetrics::Shown, 1);

[whywhat, 2017/03/07 12:50:56]

Strange you don't need to update that. Shouldn't the count be 0?

[steimel, 2017/03/07 15:26:21]

Hmm I'm not actually sure what that's measuring exactly, but if I change it to
zero then the test fails ¯\_(ツ)_/¯

 
   // Showing button again should not increment Shown count.
   mediaControls().mediaElement().setSrc("https://example.com/foo.mp4");
   testing::runPendingTasks();
   EXPECT_TRUE(isElementVisible(*downloadButton));
   histogramTester().expectBucketCount("Media.Controls.Download",
                                       DownloadActionMetrics::Shown, 1);
 }
 
 TEST_F(MediaControlsTest, DownloadButtonRecordsClickOnlyOnce) {
@@ skipping 84 matching lines @@
   // underlying <input type="range">. This would set the |value| to the |max|
   // attribute, which can be slightly rounded relative to the duration.
   timeline->setValueAsNumber(roundedUpDuration, ASSERT_NO_EXCEPTION);
   ASSERT_EQ(roundedUpDuration, timeline->valueAsNumber());
   EXPECT_EQ(0.0, mediaControls().mediaElement().currentTime());
   timeline->dispatchInputEvent();
   EXPECT_EQ(exactDuration, mediaControls().mediaElement().currentTime());
 }
 
 }  // namespace blink